Add unit tests for KindVisitor #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GautamBytes <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive unit tests for the KindVisitor utility in
pkg/internal/apps/kind_visitor.go.Changes:
TestGroupKindElement_Accept: A table-driven test has been added to ensure the Accept method correctly dispatches to the appropriate Visit function based on the resource's Group and Kind. It uses a mock KindVisitor to validate behavior and covers all existing resource types, including standard Kubernetes and Kruise-specific kinds. It also verifies that an error is correctly returned for unsupported kinds.
TestGroupKindElement_GroupMatch: A table-driven test has been added to validate the GroupMatch helper function, covering various scenarios such as single, multiple, and non-matching groups.