Skip to content

OCPEDGE-2015: Lvm operator sno integration #71313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2025
Merged

OCPEDGE-2015: Lvm operator sno integration #71313

merged 3 commits into from
Nov 13, 2025
+1 −63

Conversation

@jeff-roche
Copy link
Contributor

@jeff-roche jeff-roche commented Nov 12, 2025

No description provided.

frobware and others added 3 commits November 12, 2025 12:53
@frobware @jeff-roche
Remove verified label requirement for main branch in bpfman-operator (o…
e1f249e 
…penshift#68879)

The main branch should not require the verified label as it's intended for
development work that doesn't need the same verification requirements as
release branches. This resolves the conflict between the includedBranches
section requiring verified and the excludedBranches section that already
excludes main from other requirements.
@frobware @jeff-roche
Remove verified label requirement for main branch in bpfman-operator (o…
f5f0947 
…penshift#68879)

The main branch should not require the verified label as it's intended for
development work that doesn't need the same verification requirements as
release branches. This resolves the conflict between the includedBranches
section requiring verified and the excludedBranches section that already
excludes main from other requirements.
@jeff-roche
fix: switching the lvm operator sno integration job to use the sno sp…
6d4c761 
…ecific suite

Signed-off-by: Jeff Roche <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025 •
edited by openshift-ci bot
Loading

@jeff-roche: This pull request references OCPEDGE-2015 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@openshift-ci openshift-ci bot requested review from jaypoulz and jerpeter1 November 12, 2025 18:02
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

[REHEARSALNOTIFIER]
@jeff-roche: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-lvm-operator-main-e2e-aws-single-node-integration-tests openshift/lvm-operator presubmit Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-e2e-aws-single-node-integration-tests N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jeff-roche
Copy link
Contributor Author

jeff-roche commented Nov 12, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

@jeff-roche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jeff-roche
Copy link
Contributor Author

jeff-roche commented Nov 13, 2025

cc @mmakwana30

@jeff-roche
Copy link
Contributor Author

jeff-roche commented Nov 13, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2025

@jeff-roche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 13, 2025
@mmakwana30
Copy link
Contributor

mmakwana30 commented Nov 13, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche, mmakwana30

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 038cb00 into openshift:master Nov 13, 2025
17 checks passed
@jeff-roche jeff-roche deleted the lvm-operator-sno-integration branch November 13, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaypoulz jaypoulz Awaiting requested review from jaypoulz

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@mmakwana30 mmakwana30

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeff-roche @openshift-ci-robot @mmakwana30 @frobware