adding best_effort for int gather_extra runs

[sclarkso]

@raelga Per the slack discussion, I attempted this. I have not made prow changes before, so this could be the wrong direction. I added a chain file so that best_effort could be set for specific runs and not affect all runs by modifying the gather_extra step directly.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@sclarkso: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[sclarkso]

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel

[openshift-ci-robot]

@sclarkso: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[sclarkso]

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel

[openshift-ci-robot]

@sclarkso: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@sclarkso: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[venkateshsredhat]

this should be a best effort in all cases where we use them IMO .

[sclarkso]

I asked in the thread and was waiting for a response. If it can be for EVERY run of that test, then we can just modify the config to allow, and then add the best_effort: true to the step-registry I think, instead of adding the chain.

[venkateshsredhat]

Ahh i missed that . IMO yes we should .

[venkateshsredhat]

lgtm overall .

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raelga, sclarkso
Once this PR has been reviewed and has the lgtm label, please assign jharrington22 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• ci-operator/config/Azure/ARO-HCP/OWNERS
• ci-operator/step-registry/aro-hcp/provision/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment