Merge pull request #661 from bogdando/OSPRH-21650

nova04/vfio: fix storage class overriding

The storage lib component relies on network-values data for setting
control plane SC values, historically. The replacement of telemetry
data overrides this in the nova04delta and vfio DT/VA.
Fixing that by re-applying the storage component logic locally in the
DT/VA as well, while repurposing it to control-plane data instead of
network-values didn't work in CI (however, it works locally with
kustomize build).
Fix that by simply providing pvcStorageClass directly in DT/VA.
We would not have to fix that, if T-O had been taking the top scope
storageClass for its metricStorage template (that fix will be in FR5
likely).
Jira: OSPRH-21650

Reviewed-by: Harald <[email protected]>
Reviewed-by: Daniel Pawlik
Reviewed-by: Andrew Bays <[email protected]>

Author: softwarefactory-project-zuul[bot]

examples/dt/nova/nova04delta/control-plane/service-values.yaml

@@ -52,7 +52,7 @@ data:
           scrapeInterval: 30s
           storage:
             persistent:
-              # NOTE: pvcStorageClass is defined in control-plane/networking/nncp/values.yaml network-values data.storageClass
+              pvcStorageClass: local-storage
               pvcStorageRequest: 20G
               pvcStorageSelector: {}
             retention: 24h

examples/va/nvidia-vfio-passthrough/control-plane/service-values.yaml

@@ -52,7 +52,7 @@ data:
           scrapeInterval: 30s
           storage:
             persistent:
-              # NOTE: pvcStorageClass is defined in control-plane/networking/nncp/values.yaml network-values data.storageClass
+              pvcStorageClass: local-storage
               pvcStorageRequest: 20G
               pvcStorageSelector: {}
             retention: 24h