Merge pull request #476 from openzim/new_illustrations_api

kelson42 · web-flow · commit 39501d8e90c0 · 2025-09-25T19:54:12.000+02:00
Switched to the new illustrations API
diff --git a/src/zimcheck/checks.cpp b/src/zimcheck/checks.cpp
@@ -267,8 +267,7 @@ void test_metadata(const zim::Archive& archive, ErrorLogger& reporter) {
 void test_favicon(const zim::Archive& archive, ErrorLogger& reporter) {
     reporter.infoMsg("[INFO] Searching for Favicon...");
 
-    const auto illustrationSizes = archive.getIllustrationSizes();
-    if ( illustrationSizes.find(48) == illustrationSizes.end() )
+    if ( archive.getIllustrationInfos(48, 48, 1).empty() )
       reporter.addMsg(MsgId::MISSING_FAVICON, {});
 }
 

Original file line number	Diff line number	Diff line change
`@@ -267,8 +267,7 @@ void test_metadata(const zim::Archive& archive, ErrorLogger& reporter) {`
`267`	`267`	`void test_favicon(const zim::Archive& archive, ErrorLogger& reporter) {`
`268`	`268`	`reporter.infoMsg("[INFO] Searching for Favicon...");`
`269`	`269`
`270`		`- const auto illustrationSizes = archive.getIllustrationSizes();`
`271`		`- if ( illustrationSizes.find(48) == illustrationSizes.end() )`
	`270`	`+ if ( archive.getIllustrationInfos(48, 48, 1).empty() )`
`272`	`271`	`reporter.addMsg(MsgId::MISSING_FAVICON, {});`
`273`	`272`	`}`
`274`	`273`