Address feedback: allowing pure alphanumeric titles

Author: kazuhidetonylee

src/zimwriterfs/zimcreatorfs.cpp

@@ -266,20 +266,16 @@ struct GumboOutputDestructor {
 
 inline bool isValidTitle(const std::string& title, size_t min_length)
 {
-  static const std::regex numeric_regex("[0-9]+");
   static const std::regex alphanumeric_regex("[a-zA-Z0-9]");
 
   /* 1. Ensure the title has at least 3 characters */
   bool isLongEnough = title.length() >= min_length;
 
-  /* 2. Ensure the title is not only numeric */
-  bool isNotNumeric = !std::regex_match(title, numeric_regex);
-
-  /* 3. Ensure the title contains at least one alphanumeric character
+  /* 2. Ensure the title contains at least one alphanumeric character
    * (not all special chars) */
   bool hasAlphanumeric = std::regex_search(title, alphanumeric_regex);
 
-  return isLongEnough && isNotNumeric && hasAlphanumeric;
+  return isLongEnough && hasAlphanumeric;
 }
 
 std::string ZimCreatorFS::parseAndAdaptHtml(std::string& data,

test/zimwriterfs-zimcreatorfs.cpp

@@ -179,8 +179,6 @@ TEST(ZimCreatorFSTest, ValidateTitle)
 
   EXPECT_FALSE(isValidTitle("ab", 3));
 
-  EXPECT_FALSE(isValidTitle("1234", 3));
-
   EXPECT_TRUE(isValidTitle("Title123", 3));
 
   EXPECT_TRUE(isValidTitle("Title!@#", 3));