require definition version while creating schedule

Author: elfkuzco

backend/src/zimfarm_backend/routes/schedules/logic.py

@@ -43,7 +43,6 @@
     create_offliner_instance,
     get_offliner_definition,
     get_offliner_definition_by_id,
-    get_offliner_versions,
 )
 from zimfarm_backend.db.schedule import create_schedule as db_create_schedule
 from zimfarm_backend.db.schedule import (
@@ -135,20 +134,9 @@ def create_schedule(
         raise UnauthorizedError("You are not allowed to create a schedule")
 
     if offliner_id := request.config.get("offliner", {}).get("offliner_id"):
-        if request.version:
-            offliner_definition = get_offliner_definition(
-                session, offliner_id, request.version
-            )
-        else:
-            # get the most recent offliner definition
-            results = get_offliner_versions(session, offliner_id, limit=1, skip=0)
-            if not results.versions:
-                raise RecordDoesNotExistError(
-                    f"No offliner definitions found for {offliner_id}"
-                )
-            offliner_definition = get_offliner_definition(
-                session, offliner_id, results.versions[0]
-            )
+        offliner_definition = get_offliner_definition(
+            session, offliner_id, request.version
+        )
     else:
         raise RequestValidationError(
             [

backend/src/zimfarm_backend/routes/schedules/models.py

@@ -41,9 +41,7 @@ class ScheduleCreateSchema(BaseModel):
     periodicity: SchedulePeriodicity
     tags: list[NotEmptyString] = Field(default_factory=list)
     enabled: bool
-    # version of offliner to use for validation. Determine latest version to use
-    # if None is provided
-    version: str | None = None
+    version: NotEmptyString
     config: dict[str, Any]  # will be validated in the route
     notification: ScheduleNotificationSchema | None = None
     context: NotEmptyString | None = None

backend/tests/routes/test_schedules.py

@@ -168,6 +168,7 @@ def test_get_similar_schedules(
                 },
                 "enabled": True,
                 "periodicity": SchedulePeriodicity.manually.value,
+                "version": "initial",
             },
             HTTPStatus.UNPROCESSABLE_ENTITY,
             id="invalid-config-missing-offliner-id",
@@ -200,6 +201,7 @@ def test_get_similar_schedules(
                     "monitor": True,
                 },
                 "enabled": True,
+                "version": "initial",
                 "periodicity": SchedulePeriodicity.manually.value,
             },
             HTTPStatus.UNPROCESSABLE_ENTITY,
@@ -266,6 +268,7 @@ def test_get_similar_schedules(
                 },
                 "enabled": True,
                 "periodicity": SchedulePeriodicity.manually.value,
+                "version": "initial",
             },
             HTTPStatus.OK,
             id="valid-config",
@@ -867,6 +870,7 @@ def test_create_duplicate_schedule(
             ),
             "enabled": True,
             "periodicity": SchedulePeriodicity.manually.value,
+            "version": "initial",
         },
     )
     assert response.status_code == HTTPStatus.CONFLICT