Merge pull request #20968 from opf/bug/68825-incorrect-phrasing-copy-as-one-time-in-more-menu-of-meeting-series

[#68825] Incorrect phrasing "Copy as one-time" in More menu of meeting series

Author: mrmir

modules/meeting/app/components/meetings/header_component.html.erb

@@ -83,7 +83,7 @@
               data: { turbo_stream: true }
             }
           ) do |item|
-            item.with_leading_visual_icon(icon: :copy)
+            item.with_leading_visual_icon(icon: :duplicate)
           end
 
           menu.with_item(

modules/meeting/app/components/meetings/header_component.rb

@@ -145,9 +145,9 @@ def delete_label
 
     def copy_label
       if @series.present?
-        I18n.t("label_recurring_meeting_copy")
+        I18n.t("label_recurring_meeting_duplicate")
       else
-        I18n.t("button_copy")
+        I18n.t("button_duplicate")
       end
     end
   end

modules/meeting/app/components/meetings/index/dialog_component.rb

@@ -50,7 +50,7 @@ def render?
     end
 
     def title
-      return I18n.t(:label_meeting_copy) if @copy_from
+      return I18n.t(:label_meeting_duplicate) if @copy_from
       return I18n.t(:label_meeting_edit) if @meeting.persisted?
 
       case @meeting

modules/meeting/app/components/meetings/row_component.rb

@@ -125,14 +125,14 @@ def view_meeting_series(menu)
     def copy_action(menu)
       return unless copy_allowed?
 
-      menu.with_item(label: I18n.t(:label_meeting_copy),
+      menu.with_item(label: I18n.t(:label_meeting_duplicate),
                      href: copy_project_meeting_path(project, model),
                      content_arguments: {
                        data: {
                          turbo_stream: true
                        }
                      }) do |item|
-        item.with_leading_visual_icon(icon: :copy)
+        item.with_leading_visual_icon(icon: :duplicate)
       end
     end
 

modules/meeting/config/locales/en.yml

@@ -132,7 +132,7 @@ en:
   label_meeting_new_dynamic: "New one-time meeting"
   label_meeting_new_recurring: "New recurring meeting"
   label_meeting_create: "Create meeting"
-  label_meeting_copy: "Copy meeting"
+  label_meeting_duplicate: "Duplicate meeting"
   label_meeting_edit: "Edit Meeting"
   label_meeting_agenda: "Agenda"
   label_meeting_minutes: "Minutes"
@@ -153,7 +153,7 @@ en:
   label_template: "Template"
   label_recurring_meeting_view: "View meeting series"
   label_recurring_meeting_create: "Open"
-  label_recurring_meeting_copy: "Copy as one-time"
+  label_recurring_meeting_duplicate: "Duplicate as a one-time meeting"
   label_recurring_meeting_cancel: "Cancel this occurrence"
   label_recurring_meeting_delete: "Delete occurrence"
   label_recurring_meeting_restore: "Restore this occurrence"

modules/meeting/spec/components/meetings/row_component_spec.rb

@@ -130,7 +130,7 @@
         let(:meeting) { build_stubbed(:meeting, project:) }
 
         it "shows copy menu item" do
-          expect(subject).to have_link "Copy meeting"
+          expect(subject).to have_link "Duplicate meeting"
         end
       end
     end

modules/meeting/spec/features/structured_meetings/structured_meeting_crud_spec.rb

@@ -285,7 +285,7 @@
     expect(page).to have_css(".flash", text: I18n.t("activerecord.errors.messages.error_conflict"))
   end
 
-  it "can copy the meeting via the dialog form" do
+  it "can duplicate the meeting via the dialog form" do
     show_page.add_agenda_item do
       fill_in "Title", with: "My agenda item"
       fill_in "Duration", with: "25"
@@ -308,9 +308,9 @@
 
     retry_block do
       click_on("op-meetings-header-action-trigger")
-      click_on "Copy"
+      click_on "Duplicate"
       # dynamically wait for the modal to be loaded
-      show_page.expect_modal("Copy meeting")
+      show_page.expect_modal("Duplicate meeting")
     end
 
     fill_in "Title", with: ""

modules/meeting/spec/support/pages/meetings/index.rb

@@ -103,13 +103,13 @@ def expect_create_new_types
 
     def expect_copy_action(meeting)
       within more_menu(meeting) do
-        expect(page).to have_link("Copy meeting")
+        expect(page).to have_link("Duplicate meeting")
       end
     end
 
     def expect_no_copy_action(meeting)
       within more_menu(meeting) do
-        expect(page).to have_no_link("Copy meeting")
+        expect(page).to have_no_link("Duplicate meeting")
       end
     end