[#66124] Overview widgets for Budgets #20966
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myabc
added
DO NOT MERGE
feature
ruby
myabc
force-pushed
the
feature/66124-overview-widget-budgets
branch
2 times, most recently
from
d5d96ca to
4f16ffc
Compare
myabc
force-pushed
the
feature/66124-overview-widget-budgets
branch
from
4f16ffc to
e998652
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public setQueryProps() { | ||
| this.datasets = []; | ||
|
|
||
| const params = this.graphParams; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 19 days ago
To fix the problem, we should remove the unused declaration and assignment of the params variable from the setQueryProps() method in the BudgetOverviewGraphComponent class. Specifically, delete line 78 (const params = this.graphParams;) entirely. No further changes are needed, as the rest of the commented code is already non-executable, and params is not used elsewhere in the method.
Suggested changeset
1
frontend/src/app/shared/components/budget-graphs/overview/budget-overview-graph.component.ts
| @@ -75,7 +75,6 @@ | ||
| public setQueryProps() { | ||
| this.datasets = []; | ||
|
|
||
| const params = this.graphParams; | ||
|
|
||
| // this.graphConfigurationService.configuration = new WpGraphConfiguration(params, {}, 'horizontalBar'); | ||
| // this.graphConfigurationService.globalScope = this.globalScope; |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/66124
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist