Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#66124] Overview widgets for Budgets #20966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
[#66124] Overview widgets for Budgets #20966
Changes from all commits
c51d1b9e998652File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 13 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L13 <@typescript-eslint/no-explicit-any>(https://typescript-eslint.io/rules/no-explicit-any)
Raw output
{"ruleId":"@typescript-eslint/no-explicit-any","severity":2,"message":"Unexpected any. Specify a different type.","line":13,"column":14,"nodeType":"TSAnyKeyword","messageId":"unexpectedAny","endLine":13,"endColumn":17,"suggestions":[{"messageId":"suggestUnknown","fix":{"range":[719,722],"text":"unknown"},"desc":"Use `unknown` instead, this will force you to explicitly, and safely assert the type is correct."},{"messageId":"suggestNever","fix":{"range":[719,722],"text":"never"},"desc":"Use `never` instead, this is useful when instantiating generic type parameters that you don't need to know the type of."}]}Check failure on line 34 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L22-L34 <@angular-eslint/prefer-on-push-component-change-detection>(https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-on-push-component-change-detection.md)
Raw output
{"ruleId":"@angular-eslint/prefer-on-push-component-change-detection","severity":2,"message":"The component's `changeDetection` value should be set to `ChangeDetectionStrategy.OnPush`","line":22,"column":1,"nodeType":"Decorator","messageId":"preferOnPushComponentChangeDetection","endLine":34,"endColumn":3,"suggestions":[{"messageId":"suggestAddChangeDetectionOnPush","fix":{"range":[51,853],"text":", ChangeDetectionStrategy } from '@angular/core';\nimport { WorkPackageTableConfiguration } from 'core-app/features/work-packages/components/wp-table/wp-table-configuration';\nimport { ChartOptions } from 'chart.js';\nimport { I18nService } from 'core-app/core/i18n/i18n.service';\nimport { GroupObject } from 'core-app/features/hal/resources/wp-collection-resource';\nimport { CommonModule } from '@angular/common';\nimport { BaseChartDirective, provideCharts, withDefaultRegisterables } from 'ng2-charts';\nimport ChartDataLabels from 'chartjs-plugin-datalabels';\nimport PrimerColorsPlugin from '../plugin.primer-colors';\n\nexport interface BudgetEmbeddedGraphDataset {\n label:string;\n queryProps:any;\n queryId?:number|string;\n groups?:GroupObject[];\n}\ninterface ChartDataSet {\n label:string;\n data:number[];\n}\n\n@Component({\n changeDetection: ChangeDetectionStrategy.OnPush,"},"desc":"Add `ChangeDetectionStrategy.OnPush`"}]}Check failure on line 60 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L60 <@angular-eslint/prefer-inject>(https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-inject.md)
Raw output
{"ruleId":"@angular-eslint/prefer-inject","severity":2,"message":"Prefer using the inject() function over constructor parameter injection. Use Angular's migration schematic to automatically refactor: ng generate @angular/core:inject","line":60,"column":15,"nodeType":"TSParameterProperty","messageId":"preferInject","endLine":60,"endColumn":40}Check failure on line 77 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L77 <@typescript-eslint/no-unsafe-assignment>(https://typescript-eslint.io/rules/no-unsafe-assignment)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-assignment","severity":2,"message":"Unsafe assignment of an `any` value.","line":77,"column":13,"nodeType":"VariableDeclarator","messageId":"anyAssignment","endLine":77,"endColumn":79}Check failure on line 77 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L77 <@typescript-eslint/prefer-nullish-coalescing>(https://typescript-eslint.io/rules/prefer-nullish-coalescing)
Raw output
{"ruleId":"@typescript-eslint/prefer-nullish-coalescing","severity":2,"message":"Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.","line":77,"column":38,"nodeType":"Punctuator","messageId":"preferNullishOverOr","endLine":77,"endColumn":40,"suggestions":[{"messageId":"suggestNullish","data":{"equals":""},"fix":{"range":[2216,2218],"text":"??"},"desc":"Fix to nullish coalescing operator (`??`)."}]}Check failure on line 77 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L77 <@typescript-eslint/no-unsafe-return>(https://typescript-eslint.io/rules/no-unsafe-return)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-return","severity":2,"message":"Unsafe return of a value of type `any`.","line":77,"column":60,"nodeType":"MemberExpression","messageId":"unsafeReturn","endLine":77,"endColumn":71}Check failure on line 77 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L77 <@typescript-eslint/no-explicit-any>(https://typescript-eslint.io/rules/no-explicit-any)
Raw output
{"ruleId":"@typescript-eslint/no-explicit-any","severity":2,"message":"Unexpected any. Specify a different type.","line":77,"column":76,"nodeType":"TSAnyKeyword","messageId":"unexpectedAny","endLine":77,"endColumn":79,"suggestions":[{"messageId":"suggestUnknown","fix":{"range":[2254,2257],"text":"unknown"},"desc":"Use `unknown` instead, this will force you to explicitly, and safely assert the type is correct."},{"messageId":"suggestNever","fix":{"range":[2254,2257],"text":"never"},"desc":"Use `never` instead, this is useful when instantiating generic type parameters that you don't need to know the type of."}]}Check failure on line 78 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L78 <@typescript-eslint/no-unsafe-argument>(https://typescript-eslint.io/rules/no-unsafe-argument)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-argument","severity":2,"message":"Unsafe argument of type `any` assigned to a parameter of type `ConcatArray<never>`.","line":78,"column":27,"nodeType":"Identifier","messageId":"unsafeArgument","endLine":78,"endColumn":33}Check failure on line 82 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L82 <@typescript-eslint/prefer-nullish-coalescing>(https://typescript-eslint.io/rules/prefer-nullish-coalescing)
Raw output
{"ruleId":"@typescript-eslint/prefer-nullish-coalescing","severity":2,"message":"Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.","line":82,"column":40,"nodeType":"Punctuator","messageId":"preferNullishOverOr","endLine":82,"endColumn":42,"suggestions":[{"messageId":"suggestNullish","data":{"equals":""},"fix":{"range":[2419,2421],"text":"??"},"desc":"Fix to nullish coalescing operator (`??`)."}]}Check failure on line 82 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L82 <@typescript-eslint/no-explicit-any>(https://typescript-eslint.io/rules/no-explicit-any)
Raw output
{"ruleId":"@typescript-eslint/no-explicit-any","severity":2,"message":"Unexpected any. Specify a different type.","line":82,"column":54,"nodeType":"TSAnyKeyword","messageId":"unexpectedAny","endLine":82,"endColumn":57,"suggestions":[{"messageId":"suggestUnknown","fix":{"range":[2433,2436],"text":"unknown"},"desc":"Use `unknown` instead, this will force you to explicitly, and safely assert the type is correct."},{"messageId":"suggestNever","fix":{"range":[2433,2436],"text":"never"},"desc":"Use `never` instead, this is useful when instantiating generic type parameters that you don't need to know the type of."}]}Check failure on line 85 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L82-L85 <@typescript-eslint/no-unsafe-assignment>(https://typescript-eslint.io/rules/no-unsafe-assignment)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-assignment","severity":2,"message":"Unsafe assignment of an `any` value.","line":82,"column":13,"nodeType":"VariableDeclarator","messageId":"anyAssignment","endLine":85,"endColumn":14}Check failure on line 85 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L82-L85 <@typescript-eslint/no-unsafe-return>(https://typescript-eslint.io/rules/no-unsafe-return)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-return","severity":2,"message":"Unsafe return of a value of type `any`.","line":82,"column":77,"nodeType":"ObjectExpression","messageId":"unsafeReturn","endLine":85,"endColumn":8}Check failure on line 89 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L89 <@typescript-eslint/no-unsafe-return>(https://typescript-eslint.io/rules/no-unsafe-return)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-return","severity":2,"message":"Unsafe return of a value of type `any`.","line":89,"column":41,"nodeType":"LogicalExpression","messageId":"unsafeReturn","endLine":89,"endColumn":61}Check failure on line 89 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L89 <@typescript-eslint/no-unsafe-member-access>(https://typescript-eslint.io/rules/no-unsafe-member-access)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-member-access","severity":2,"message":"Unsafe member access [label] on an `any` value.","line":89,"column":50,"nodeType":"Identifier","messageId":"unsafeMemberExpression","endLine":89,"endColumn":55}Check failure on line 89 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L89 <@typescript-eslint/prefer-nullish-coalescing>(https://typescript-eslint.io/rules/prefer-nullish-coalescing)
Raw output
{"ruleId":"@typescript-eslint/prefer-nullish-coalescing","severity":2,"message":"Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.","line":89,"column":57,"nodeType":"Punctuator","messageId":"preferNullishOverOr","endLine":89,"endColumn":59,"suggestions":[{"messageId":"suggestNullish","data":{"equals":""},"fix":{"range":[2628,2630],"text":"??"},"desc":"Fix to nullish coalescing operator (`??`)."}]}Check failure on line 207 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L207 <@typescript-eslint/prefer-optional-chain>(https://typescript-eslint.io/rules/prefer-optional-chain)
Raw output
{"ruleId":"@typescript-eslint/prefer-optional-chain","severity":2,"message":"Prefer using an optional chain expression instead, as it's more concise and easier to read.","line":207,"column":47,"nodeType":null,"messageId":"preferOptionalChain","endLine":207,"endColumn":80,"suggestions":[{"fix":{"range":[6176,6209],"text":"this.datasets?.[0]"},"messageId":"optionalChainSuggest","desc":"Change to an optional chain."}]}Check failure on line 210 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L210 <@typescript-eslint/no-unsafe-argument>(https://typescript-eslint.io/rules/no-unsafe-argument)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-argument","severity":2,"message":"Unsafe argument of type `any` assigned to a parameter of type `string`.","line":210,"column":30,"nodeType":"MemberExpression","messageId":"unsafeArgument","endLine":210,"endColumn":37}Check failure on line 211 in frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts
[eslint] frontend/src/app/shared/components/budget-graphs/embedded/budget-embedded-graph.component.ts#L211 <@typescript-eslint/no-unsafe-argument>(https://typescript-eslint.io/rules/no-unsafe-argument)
Raw output
{"ruleId":"@typescript-eslint/no-unsafe-argument","severity":2,"message":"Unsafe argument of type `any` assigned to a parameter of type `string`.","line":211,"column":23,"nodeType":"MemberExpression","messageId":"unsafeArgument","endLine":211,"endColumn":30}Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.