pass test-worker-nested-uncaught.js #19509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 2:34 PM PT - May 12th, 2025
❌ @190n, your commit 3e8dd5d has 1 failures in
🧪 To try this PR locally: bunx bun-pr 19509That installs a local version of the PR into your bun-19509 --bun |
190n
force-pushed
the
ben/worker-error-event
branch
2 times, most recently
from
ae22d4f to
2a72d4d
Compare
190n
force-pushed
the
ben/worker-error-event
branch
from
2a72d4d to
7ad8381
Compare
dylan-conway
previously approved these changes
May 10, 2025
190n
requested review from
a team,
cirospaciari and
nektro
and removed request for
a team and
cirospaciari
cirospaciari
previously approved these changes
May 11, 2025
Collaborator
|
There's a merge conflict but it LGTM |
dylan-conway
approved these changes
May 12, 2025
cirospaciari
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes it so
node:worker_threadsWorkers emit anerrorevent with the exact error object that was thrown, instead of a stringified version like Web Workers.How did you verify your code works?
Added Node test and extended our existing Worker tests