Skip to content

Conversation

@pfgithub
Copy link
Collaborator

@pfgithub pfgithub commented May 9, 2025

  • Throw ERR_EVENT_RECURSION rather than a DOMError for recursion in event target
  • Throw ERR_INVALID_ARG_TYPE rather than a generic TypeError when second arg to new Event() is wrong
  • Emit uncaughtException rather than unhandledRejection for event listeners that return a promise
  • Add a custom inspect function for Event
  • Add a warning for registering a null or undefined event listener

@robobun
Copy link
Collaborator

robobun commented May 9, 2025

Updated 2:53 PM PT - May 12th, 2025

@pfgithub, your commit 58728cd has 1 failures in Build #16516:


🧪   To try this PR locally:

bunx bun-pr 19547

That installs a local version of the PR into your bun-19547 executable, so you can run:

bun-19547 --bun

@pfgithub pfgithub requested review from a team, 190n and heimskr and removed request for a team May 9, 2025 03:37
190n
190n previously approved these changes May 9, 2025
cirospaciari
cirospaciari previously approved these changes May 12, 2025
@cirospaciari cirospaciari requested a review from 190n May 12, 2025 20:20
190n
190n previously approved these changes May 12, 2025
@pfgithub pfgithub dismissed stale reviews from 190n and cirospaciari via 58728cd May 12, 2025 21:08
Copy link
Member

@cirospaciari cirospaciari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like test/bake/dev/stress.test.ts is flaky and not just in this PR

@pfgithub pfgithub requested a review from Jarred-Sumner May 16, 2025 23:59
@Jarred-Sumner Jarred-Sumner merged commit 342fe23 into main May 17, 2025
58 of 59 checks passed
@Jarred-Sumner Jarred-Sumner deleted the pfg/event-target branch May 17, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants