Add xvfb-run to Dockerfile

Author: adamhooper

docker/Dockerfile

@@ -22,6 +22,7 @@ RUN set -x \
         unzip \
         zlib1g-dev \
         tigervnc-standalone-server \
+        xvfb \
       && gem install bundler \
       && (cd /tmp && curl "http://chromedriver.storage.googleapis.com/2.35/chromedriver_linux64.zip" -o chromedriver_linux64.zip && unzip chromedriver_linux64.zip && rm -f chromedriver_linux64.zip && mv chromedriver /usr/bin/)
 

skeleton/run

@@ -10,6 +10,17 @@ set -e
 IMAGE_NAME=overview/overview-integration-tester:$OVERVIEW_INTEGRATION_TESTER_VERSION
 docker image ls -q $IMAGE_NAME >/dev/null || docker pull $IMAGE_NAME
 
+# [adamhooper, 2018-01-23] HEADLESS=true seems to break within_frame()
+# sporadically with Chrome 63 and Chromedriver 2.35. The closest report I can
+# find is https://github.com/teamcapybara/capybara/issues/1860
+#
+# Another issue with headless is that it has no folder uploads. Overview treats
+# folder uploads specially, including slashes in their filenames, and some
+# plugins (e.g., "Folders" plugin) require that test.
+#
+# If you have any problems with headless, use Xvfb instead. Set
+# -e HEADLESS=false. Then, instead of "$@", use:
+# xvfb-run --server-args='-screen 0 1200x900x24' "$@"
 exec docker run --rm -it \
   --network ${DEVELOPMENT_PROJECT_NAME}_default \
   -e OVERVIEW_URL=http://overview-web \
@@ -19,4 +30,6 @@ exec docker run --rm -it \
   -v "$ABSDIR"/helpers:/app/helpers \
   -v "$ABSDIR"/reports:/app/reports \
   -v "$ABSDIR"/spec:/app/spec \
-  "$IMAGE_NAME" "$@"
+  --shmem
+  "$IMAGE_NAME" \
+  "$@"