Skip to content

Conversation

@dschmidt
Copy link
Member

Description

Change the "copy link and password" action in CreateShareModal in embed mode to actually pass link(s) and password(s) to the parent application.

Related Issue

  • Fixes <issue_link>

Motivation and Context

In embed mode copying the links with passwords to clipboard is completely counterintuitive as it behaves completely different than "share links" and requires users to insert it themselves. Moreover the clipboard functionality is blocked by default in an inframe.

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Screenshot_20251112_163410

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Nov 12, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt force-pushed the feat/share-links-and-passswords branch from 803ac82 to fec0fea Compare November 12, 2025 15:45
@sonarqubecloud
Copy link

@LukasHirt LukasHirt self-requested a review November 12, 2025 16:04
@LukasHirt LukasHirt merged commit 4814e47 into master Nov 13, 2025
4 checks passed
@LukasHirt LukasHirt deleted the feat/share-links-and-passswords branch November 13, 2025 09:39
ownclouders pushed a commit that referenced this pull request Nov 13, 2025
feat: share links and passwords in embed mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants