fix: use VERSION as the source of truth

Updated the implementation to treat `VERSION` as the source of truth
instead of having a sort of split brain scenario.

Author: sudomateo

.github/ISSUE_TEMPLATE/release_checklist.md

@@ -11,12 +11,12 @@ labels: release
  After completing each task put an `x` in the corresponding box,
  and paste the link to the relevant PR.
 -->
-- [ ] Make sure the [VERSION](https://github.com/oxidecomputer/oxide.go/blob/main/VERSION) and [internal/generate/version.go](https://github.com/oxidecomputer/oxide.go/blob/main/internal/generate/version.go) files have the new version you want to release.
+- [ ] Make sure the [VERSION](https://github.com/oxidecomputer/oxide.go/blob/main/VERSION) file has the new version you want to release.
 - [ ] Make sure the changelog file in the `.changelog/` directory is set to the new version you want to release.
 - [ ] Make sure all examples and docs reference the new version.
 - [ ] Make sure you've pulled the latest tag on main, and generate changelog by running `make changelog`. Add the date of the release to the title, and update associated Oxide API version.
 - [ ] Release the new version by running `make tag`.
 - [ ] Update GitHub release description with release notes generated from `make changelog`.
 - [ ] Create a release branch from the commit of the release tag.
-- [ ] Bump the version in [VERSION](https://github.com/oxidecomputer/oxide.go/blob/main/VERSION) and [internal/generate/version.go](https://github.com/oxidecomputer/oxide.go/blob/main/internal/generate/version.go).
+- [ ] Bump the version in [VERSION](https://github.com/oxidecomputer/oxide.go/blob/main/VERSION) and run `make generate` to update the generated files.
 - [ ] Create a new file for the next release in [.changelog/](https://github.com/oxidecomputer/oxide.go/blob/main/.changelog/).

CONTRIBUTING.md

@@ -16,9 +16,8 @@ $ make all
 
 ## Releasing a new SDK version
 
-1. Make sure the following files have the new version you want to release.
-   - [`VERSION`](./VERSION)
-   - [`oxide/version.go`](./oxide/version.go): Updated via [`internal/generate/version.go`](./internal/generate/version.go)
+1. Update the [`VERSION`](./VERSION) file with the new version you want to release.
+   - The [`oxide/version.go`](./oxide/version.go) file will be automatically updated when you run `make generate`
 2. Make sure you have run `make all` and pushed any changes. The release
    will fail if running `make all` causes any changes to the generated
    code.

internal/generate/main.go

@@ -44,6 +44,12 @@ func generateSDK() error {
 		}
 	}
 
+	sdkVersionFile := "../VERSION"
+	sdkVersion, err := loadSDKVersionFromFile(sdkVersionFile)
+	if err != nil {
+		return err
+	}
+
 	typesFile := "../../oxide/types.go"
 	if err := generateTypes(typesFile, spec); err != nil {
 		return err
@@ -60,13 +66,33 @@ func generateSDK() error {
 	}
 
 	versionFile := "../../oxide/version.go"
-	if err := generateVersion(versionFile, spec); err != nil {
+	if err := generateVersion(versionFile, spec, sdkVersion); err != nil {
 		return err
 	}
 
 	return nil
 }
 
+func loadSDKVersionFromFile(file string) (string, error) {
+	wd, err := os.Getwd()
+	if err != nil {
+		return "", fmt.Errorf("error getting current working directory: %w", err)
+	}
+
+	f := filepath.Join(filepath.Dir(wd), file)
+	version, err := os.ReadFile(f)
+	if err != nil {
+		return "", fmt.Errorf("error retrieving SDK version: %w", err)
+	}
+
+	sdkVersion := strings.TrimSpace(string(version))
+	if sdkVersion == "" {
+		return "", fmt.Errorf("sdk version cannot be empty: %s", file)
+	}
+
+	return sdkVersion, nil
+}
+
 func loadAPIFromFile(file string) (*openapi3.T, error) {
 	wd, err := os.Getwd()
 	if err != nil {

internal/generate/version.go

@@ -12,7 +12,7 @@ import (
 )
 
 // generateVersion generates the version.go file with both SDK and API versions.
-func generateVersion(file string, spec *openapi3.T) error {
+func generateVersion(file string, spec *openapi3.T, sdkVersion string) error {
 	f, err := openGeneratedFile(file)
 	if err != nil {
 		return err
@@ -36,7 +36,7 @@ func generateVersion(file string, spec *openapi3.T) error {
 		SDKVersion     string
 		OpenAPIVersion string
 	}{
-		SDKVersion:     "v0.8.0",
+		SDKVersion:     sdkVersion,
 		OpenAPIVersion: apiVersion,
 	}