Merge pull request #185 from particle-iot/fix/omit-empty-querystring

monkbroc · web-flow · commit 70275e121b68 · 2024-06-21T15:22:51.000-04:00
Don't add an empty query string to the URL
diff --git a/src/Agent.js b/src/Agent.js
@@ -255,8 +255,10 @@ class Agent {
         }
         if (query) {
             const queryParams = qs.stringify(query);
-            const hasParams = actualUri.includes('?');
-            actualUri = `${actualUri}${hasParams ? '&' : '?'}${queryParams}`;
+            if (queryParams) {
+                const hasParams = actualUri.includes('?');
+                actualUri = `${actualUri}${hasParams ? '&' : '?'}${queryParams}`;
+            }
         }
 
         const userAgentHeader = { 'User-Agent': `${packageJson.name}/${packageJson.version} (${packageJson.repository.url})` };

Original file line number	Diff line number	Diff line change
`@@ -255,8 +255,10 @@ class Agent {`
`255`	`255`	`}`
`256`	`256`	`if (query) {`
`257`	`257`	`const queryParams = qs.stringify(query);`
`258`		`- const hasParams = actualUri.includes('?');`
`259`		- actualUri = `${actualUri}${hasParams ? '&' : '?'}${queryParams}`;
	`258`	`+ if (queryParams) {`
	`259`	`+ const hasParams = actualUri.includes('?');`
	`260`	+ actualUri = `${actualUri}${hasParams ? '&' : '?'}${queryParams}`;
	`261`	`+ }`
`260`	`262`	`}`
`261`	`263`
`262`	`264`	const userAgentHeader = { 'User-Agent': `${packageJson.name}/${packageJson.version} (${packageJson.repository.url})` };