Update CI to test against Ruby 3.4 and Rails 8 #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l::Logger` `concurrent-ruby` `v1.3.5` doesn't automatically require `logger` anymore, which rails < 7.1 depends on. See rails/rails#54260
Test were failing with the following error:
```
An error occurred while loading spec_helper.rb. - Did you mean?
rspec ./spec/spec_helper.rb
Failure/Error: require "rails"
LoadError:
cannot load such file -- mutex_m
No examples found.
```
We were also getting the following warning:
```
/opt/hostedtoolcache/Ruby/3.4.7/x64/lib/ruby/gems/3.4.0/gems/activesupport-6.1.7.10/lib/active_support/dependencies.rb:299: warning: mutex_m was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.
You can add mutex_m to your Gemfile or gemspec to silence this warning.
Also please contact the author of activesupport-6.1.7.10 to request adding mutex_m into its gemspec.
```
In order to fix this we should add `mutex_m` to Rails 6.1 appraisal when
using Ruby 3.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pat! Thank you so much for working on this gem! ❤️
This PR updates the CI to test against Ruby 3.4 and Rails 8, as well as fixing some errors that were causing the CI to fail.