onChange should fire only for valid option with key (#140)

peacechen · peacechen · commit 825d94d7809c · 2021-07-07T08:17:06.000-05:00
diff --git a/index.js b/index.js
@@ -175,6 +175,9 @@ export default class ModalSelector extends React.Component {
     }
 
     onChange = (item) => {
+        if (!item || !item.key) {
+          return;
+        }
         this.props.onChange(item);
         this.setState({ selected: this.props.labelExtractor(item), changedItem: item }, () => {
           if (this.props.closeOnChange)

Original file line number	Diff line number	Diff line change
`@@ -175,6 +175,9 @@ export default class ModalSelector extends React.Component {`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`onChange = (item) => {`
	`178`	`+ if (!item \|\| !item.key) {`
	`179`	`+ return;`
	`180`	`+ }`
`178`	`181`	`this.props.onChange(item);`
`179`	`182`	`this.setState({ selected: this.props.labelExtractor(item), changedItem: item }, () => {`
`180`	`183`	`if (this.props.closeOnChange)`