Add check_spi option #996
Open
Add check_spi option #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Stripe iOS SDK, we use Periphery with the
retain_publicoption enabled to check for dead code while ignoring our many public APIs. However, we also use@_spiattributes throughout our SDK to create internal APIs only for use by our own modules. We would like Periphery to scan these declarations and report if they are unused, as if they were internal, but currently theretain_publicoption causes Periphery to ignore them.This PR introduces a new
check_spioption that takes in a list of@_spiflags to always check, regardless of theretain_publicusage.