Better Configuration Parsing #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dds support for specific file inclusion. Adds support for file and directory exclusion. Unit tests.
MrDys
commented
Nov 5, 2025
Comment on lines
-134
to
-138
| $files = Finder::create() | ||
| ->in($source) | ||
| ->name('*.php') | ||
| ->notName('*.blade.php') | ||
| ->files(); |
Author
There was a problem hiding this comment.
This is moved into ConfigurationSourceDetector::detect() because it now needs to create and return a list of files to be checked (so that exclusions can be properly handled).
Author
|
@nunomaduro What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
This PR handles two related things:
-cand--configurationflags that the rest of Pest uses to pass a phpunit.xml file do not work. Only--configuration=works. This PR makes it such that both-cand--configurationwork, with and without the=.