This repository was archived by the owner on Jul 15, 2021. It is now read-only.
More customization for address check since some folks would like to u… #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se what they wrote in customer.json instead of nvidia suggested one
|
Thanks @hwamil, this would be useful for myself as I have an address that never gets picked up correctly using auto suggestions. |
Owner
|
Looks like something we need, but not sure if the IDs are correct 🤔 Let's wait for the API / checkout to come back online! |
…n instead of interacting within run
…niper into skipAddressCheck
|
This always gets me as well with my address - would be a great feature to have |
philippnormann
force-pushed
the
master
branch
from
00e2d3c to
2aa2141
Compare
…r.json sniper does not expand shipping during checkout hence opting to have same shipping address as billing address.
… failing and asking for intervention. May want to send notification at n attempts
philippnormann
force-pushed
the
master
branch
from
edbe723 to
3236954
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…se what they wrote in customer.json instead of the Nvidia suggested one.
I've added two user-determined boolean variables in main() that gets piped into nvidia.checkout_guest() > nvidia.skip_address_check(). This lets the user decide wether or not they want to use their own addresses in customer.json or the Nvidia/DR suggested one during checkout.