Update Configuration.php for deprecation fix SF5.0 #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tifabien
suggested changes
Mar 11, 2020
| $treeBuilder = new TreeBuilder(); | ||
| $rootNode = $treeBuilder->root('pix_sortable_behavior'); | ||
| $treeBuilder = new TreeBuilder('pix_sortable_behavior'); | ||
| $rootNode = $treeBuilder->getRootNode(); |
There was a problem hiding this comment.
I would add a BC layer for this deprecation notice
Suggested change
| $rootNode = $treeBuilder->getRootNode(); | |
| $builder = new TreeBuilder('pix_sortable_behavior'); | |
| if (\method_exists($builder, 'getRootNode')) { | |
| $rootNode = $builder->getRootNode(); | |
| } else { | |
| // BC layer for symfony/config 4.1 and older | |
| $rootNode = $builder->root('pix_sortable_behavior'); | |
| } |
|
Hi @nicolasricci , could you merge it? thanks |
|
Any news about it ? I need it too ! |
Member
|
@remigarcia @tifabien Sorry guys, not been using this bundle for a while and I don't really have time to maintain it at the minute. Would any (or both) of you be interested to be added to the repository to maintain it? |
|
Sonata admin officially migrated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.