Adjust accounts, with type

[jacogr]

Change this interface https://github.com/polkadot-js/extension/blob/master/packages/extension-inject/src/types.ts#L27-L30 to cater for non-ss58 accounts.

Basically add a getAll(), marking get as deprecated. With getAll, return [<sr25519 | ed25519 | ethereum | ...>, InjectedAcocunt][]

Since the type can be derived anyway from on-chain data, this is non-exposing. Then the logic would be -

• when get is called, only return the ss58-accounts, i.e. don't break userspace
• when getAll is called, return, well, everything with type

Needed for -

• Change loadInjected to handle ethereum addresses ui#413
• Add metamask extension web3 #566
• Support ethereum accounts #560

The alternative would be the following -

• add a type?: KeyringType to the AccountInjected
• add a flag to get(withType?: boolean) which will populate the type (if not supplied, same non-eth filter as above)

This is probably preferable since it has less working-with-data changes on the users of the interface, however they still need to opt-in.

[Tbaut]

Thanks for the detailed explanation, adding it now.

[polkadot-js-bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.