-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Open
Labels
Description
Pattern matching syntax, for example:
if (!(catalog instanceof ViewCatalog viewCatalog)) {
throw new PrestoException(NOT_SUPPORTED, "This connector does not support creating Iceberg views for materialized views");
}
viewCatalog...Causes our checkstyle plugin to fail:
Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (checkstyle) on project presto-iceberg: Failed during checkstyle configuration: Exception was thrown while processing /home/runner/work/presto/presto/presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergNativeMetadata.java: MismatchedTokenException occurred while parsing file /home/runner/work/presto/presto/presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergNativeMetadata.java. expecting EOF, found '}' -> [Help 1]
We should upgrade our checkstyle plugin to allow use of new language features.
Your Environment
- Presto version used: trunk
- Storage (HDFS/S3/GCS..): n/a
- Data source and connector used: n/a
- Deployment (Cloud or On-prem): n/a
- Pastebin link to the complete debug logs:
Expected Behavior
Java 17 language features are properly parsed by the checkstyle plugin
Current Behavior
It errors as described above
Possible Solution
Upgrade the checkstyle plugin used
Steps to Reproduce
Screenshots (if appropriate)
Context
imjalpreet
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
🆕 Unprioritized