Skip to content

Commit 934bc59

Browse files
authored
test: php 8.4 (#1044)
* Test PHP 8.4 * Update JsValidationServiceProviderTest.php
1 parent 314418b commit 934bc59

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/workflows/php-tests.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,14 @@ jobs:
1313
strategy:
1414
matrix:
1515
laravel: ['9', '10', '11']
16-
php: ['8.1', '8.2', '8.3']
16+
php: ['8.1', '8.2', '8.3', '8.4']
1717
exclude:
1818
- laravel: '11'
1919
php: '8.1'
20+
- laravel: '9'
21+
php: '8.4'
22+
- laravel: '10'
23+
php: '8.4'
2024

2125
name: PHP ${{ matrix.php }} Laravel ${{ matrix.laravel }}
2226

tests/JsValidationServiceProviderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public function testRegister()
111111
$mock->register();
112112
}
113113

114-
protected function assertConfigMerged(string $file, string $configKey = null): void
114+
protected function assertConfigMerged(string $file, ?string $configKey = null): void
115115
{
116116
$configKey ??= Str::of($file)->beforeLast('.php')->afterLast('/')->afterLast('\\')->toString();
117117

0 commit comments

Comments
 (0)