Skip to content

Commit 73ed1a2

Browse files
Fix fresh installation issue in fall2024 version (#789)
* Pin docker-ce to version <28.0.0 to prevent Traefik incompatibility * Updated docker-ce version * Fix Docker installation to exclude incompatible version 29.x * Update scripts/ubuntu/1-install-dependencies.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update scripts/ubuntu/1-install-dependencies.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 3f7af8e commit 73ed1a2

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

scripts/ubuntu/1-install-dependencies.sh

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,23 @@ readarray packagelist < "$UBUNTU_SCRIPT_DIR/package-dependency-list.txt"
3939
SAVEIFS=$IFS
4040
IFS=$(echo -en "\r")
4141
for package in ${packagelist[@]}; do
42-
print_script_step "Instaling package: ${package[@]}"
43-
sudo DEBIAN_FRONTEND=noninteractive apt-get satisfy ${package[@]} -y --allow-downgrades
42+
print_script_step "Installing package: ${package[@]}"
43+
44+
# Special handling for docker-ce to avoid version 29.x
45+
if [[ "${package%%[[:space:]]}" == docker-ce* ]]; then
46+
# Get the latest version that is not 29.x
47+
DOCKER_VERSION=$(apt-cache madison docker-ce | awk '$3 !~ /^5:29\./ {print $3; exit}')
48+
if [ -n "$DOCKER_VERSION" ]; then
49+
print_script_step "Installing docker-ce version $DOCKER_VERSION (excluding 29.x)"
50+
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y --allow-downgrades docker-ce=$DOCKER_VERSION docker-ce-cli=$DOCKER_VERSION containerd.io
51+
sudo apt-mark hold docker-ce docker-ce-cli
52+
else
53+
echo "ERROR: No suitable docker-ce version found (excluding 29.x)"
54+
exit 1
55+
fi
56+
else
57+
sudo DEBIAN_FRONTEND=noninteractive apt-get satisfy "${package%%[[:space:]]}" -y --allow-downgrades
58+
fi
4459
done
4560
IFS=$SAVEIFS
4661

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
docker-ce (>=5:24.0.7-1~ubuntu.22.04~jammy)
1+
docker-ce (<< 5:29.0)
22
python3-pip (>=24.0+dfsg-1ubuntu1)
33
python3-venv (>=3.12.3-0ubuntu1)

0 commit comments

Comments
 (0)