Update the naming of modeselect command to be consistent with modebase. #42237
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on project-chip#42200 (review) Although modeselect uses this method in startup, it is not used only in startup .... so keeping the name the same.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the SetStartupOnMode function to UpdateCurrentModeToOnMode in the ModeSelect integration to align with the naming convention already used in ModeBase integration. The change is purely a refactoring to improve naming consistency across the codebase.
Key changes:
- Renamed
SetStartupOnModetoUpdateCurrentModeToOnModein ModeSelect integration - Updated all call sites in the on-off-server implementation
- Minor formatting adjustment to constructor initialization list
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mode-select-integration.h | Updated function declaration and inline stub to use the new name UpdateCurrentModeToOnMode |
| mode-select-integration.cpp | Updated function implementation to use the new name UpdateCurrentModeToOnMode |
| on-off-server.cpp | Updated all call sites to use the new function name and minor formatting adjustment to constructor initialization list |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the naming of a function in the ModeSelect integration to be more consistent with a similar function in ModeBase integration. The function SetStartupOnMode has been renamed to UpdateCurrentModeToOnMode, which more accurately reflects its usage beyond just startup scenarios. The changes are applied consistently across the function's declaration, definition, and call sites. This is a good improvement for code clarity and consistency.
|
PR #42237: Size comparison from bee7cc7 to 13ab1f5 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
bzbarsky-apple
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is based on
#42200 (review)
Although modeselect uses this method in startup, it is not used only in startup .... so keeping the name the same.
Testing
just API name change ... no functionality behavior (so CI still applies)