Various fixes suggested by copilot

Signed-off-by: Brian Goff <[email protected]>

Author: cpuguy83

docs/spec.schema.json

@@ -957,14 +957,14 @@
 						"string",
 						"null"
 					],
-					"description": "Header is the name of the secret which contains the git auth header.\nwhen using git auth header based authentication.\nNote: This should not have the *actual* secret value, just the name of\nthe secret which was specified as a build secret."
+					"description": "Header is the name of the secret which contains the git auth header.\nWhen using git auth header based authentication.\nNote: This should not have the *actual* secret value, just the name of\nthe secret which was specified as a build secret."
 				},
 				"ssh": {
 					"type": [
 						"string",
 						"null"
 					],
-					"description": "SSH is the name of the secret which contains the ssh auth into when using\nssh based auth.\nNote: This should not have the *actual* secret value, just the name of\nthe secret which was specified as a build secret."
+					"description": "SSH is the name of the secret which contains the ssh auth info when using\nssh based auth.\nNote: This should not have the *actual* secret value, just the name of\nthe secret which was specified as a build secret."
 				},
 				"token": {
 					"type": [

helpers.go

@@ -705,7 +705,7 @@ func ErrorState(in llb.State, err error) llb.State {
 	return asyncState(in, err)
 }
 
-// NoopStateOption returns a [llb.StateOption] that does not change the input state.
+// NoopStateOption is a [llb.StateOption] that does not change the input state.
 func NoopStateOption(in llb.State) llb.State {
 	return in
 }

source_git.go

@@ -20,7 +20,7 @@ type SourceGit struct {
 
 type GitAuth struct {
 	// Header is the name of the secret which contains the git auth header.
-	// when using git auth header based authentication.
+	// When using git auth header based authentication.
 	// Note: This should not have the *actual* secret value, just the name of
 	// the secret which was specified as a build secret.
 	Header string `yaml:"header,omitempty" json:"header,omitempty"`
@@ -29,7 +29,7 @@ type GitAuth struct {
 	// Note: This should not have the *actual* secret value, just the name of
 	// the secret which was specified as a build secret.
 	Token string `yaml:"token,omitempty" json:"token,omitempty"`
-	// SSH is the name of the secret which contains the ssh auth into when using
+	// SSH is the name of the secret which contains the ssh auth info when using
 	// ssh based auth.
 	// Note: This should not have the *actual* secret value, just the name of
 	// the secret which was specified as a build secret.

source_inline.go

@@ -109,10 +109,6 @@ func (s *SourceInline) validate(opts fetchOptions) (retErr error) {
 		if opts.Excludes != nil {
 			errs = append(errs, errors.New("inline file source cannot have excludes set"))
 		}
-		if err := s.File.validate(); err != nil {
-			errs = append(errs, err)
-		}
-
 		if err := s.File.validate(); err != nil {
 			errs = append(errs, errors.Wrap(err, "inline file source validation failed"))
 		}

source_test.go

@@ -246,7 +246,6 @@ exit 0
 	}
 	if st == nil {
 		t.Fatal("gomod generator succeeded but return value was nil")
-		return nil, nil
 	}
 
 	def, err := st.Marshal(ctx)
@@ -814,7 +813,6 @@ func TestSourceInlineDir(t *testing.T) {
 func checkMkdir(t *testing.T, op *pb.FileOp, src *SourceInlineDir) {
 	if op == nil {
 		t.Fatal("expected dir op")
-		return
 	}
 
 	if len(op.Actions) != 1 {
@@ -824,7 +822,6 @@ func checkMkdir(t *testing.T, op *pb.FileOp, src *SourceInlineDir) {
 	mkdir := op.Actions[0].GetMkdir()
 	if mkdir == nil {
 		t.Fatalf("expected mkdir action: %v", op.Actions[0])
-		return
 	}
 
 	if mkdir.MakeParents {
@@ -854,7 +851,6 @@ func checkMkdir(t *testing.T, op *pb.FileOp, src *SourceInlineDir) {
 func checkMkfile(t *testing.T, op *pb.FileOp, src *SourceInlineFile, name string) {
 	if op == nil {
 		t.Fatal("expected file op")
-		return
 	}
 
 	if len(op.Actions) != 1 {
@@ -864,7 +860,6 @@ func checkMkfile(t *testing.T, op *pb.FileOp, src *SourceInlineFile, name string
 	mkfile := op.Actions[0].GetMkfile()
 	if mkfile == nil {
 		t.Fatalf("expected mkfile action: %v", op.Actions[0])
-		return
 	}
 
 	uid := mkfile.Owner.User.GetByID()
@@ -1164,7 +1159,6 @@ func checkFilter(t *testing.T, op *pb.FileOp, src *Source) {
 	cpAction := op.Actions[0].GetCopy()
 	if cpAction == nil {
 		t.Fatal("expected copy action")
-		return
 	}
 
 	if cpAction.Dest != "/" {