address review comments

Signed-off-by: Max Kotliar <[email protected]>

Author: makasim

exp/api/remote/remote_api_test.go

@@ -303,25 +303,25 @@ func TestRemoteAPI_Write_WithHandler(t *testing.T) {
 func TestSnappyDecodeMiddleware(t *testing.T) {
 	tLogger := slog.Default()
 
-	var actReq *writev2.Request
-	successH := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	var gotRequest *writev2.Request
+	successHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		b, err := io.ReadAll(r.Body)
 		if err != nil {
 			t.Fatalf("failed to read body: %v", err)
 		}
-		actReq = &writev2.Request{}
-		if err := proto.Unmarshal(b, actReq); err != nil {
+		gotRequest = &writev2.Request{}
+		if err := proto.Unmarshal(b, gotRequest); err != nil {
 			t.Fatalf("failed to unmarshal request: %v", err)
 		}
 
 		w.WriteHeader(http.StatusOK)
 	})
 
-	mw := SnappyDecodeMiddleware(tLogger)(successH)
+	mw := SnappyDecodeMiddleware(tLogger)(successHandler)
 
 	t.Run("success", func(t *testing.T) {
-		// populated by successH handler
-		actReq = nil
+		// populated by successHandler handler
+		gotRequest = nil
 		expReq := testV2()
 
 		serializedExpReq, err := proto.Marshal(expReq)
@@ -340,14 +340,14 @@ func TestSnappyDecodeMiddleware(t *testing.T) {
 		if rw.Code != http.StatusOK {
 			t.Fatalf("expected status 200, got %d: %s", rw.Code, rw.Body.String())
 		}
-		if diff := cmp.Diff(expReq, actReq, protocmp.Transform()); diff != "" {
+		if diff := cmp.Diff(expReq, gotRequest, protocmp.Transform()); diff != "" {
 			t.Fatalf("unexpected request after decoding: %s", diff)
 		}
 	})
 
 	t.Run("too_big", func(t *testing.T) {
-		// populated by successH handler
-		actReq = nil
+		// populated by successHandler handler
+		gotRequest = nil
 
 		s := writev2.NewSymbolTable()
 		expReq := &writev2.Request{}
@@ -383,8 +383,8 @@ func TestSnappyDecodeMiddleware(t *testing.T) {
 		}
 
 		body := rw.Body.String()
-		if !strings.Contains(body, "decoded size exceeds maximum allowed") {
-			t.Fatalf("expected error message about size limit, got: %s", body)
+		if !strings.Contains(body, "decoded size exceeds the") {
+			t.Fatalf("expected decoded size exceeds error, got: %s", body)
 		}
 	})
 
@@ -407,8 +407,8 @@ func TestSnappyDecodeMiddleware(t *testing.T) {
 		}
 
 		body := rw.Body.String()
-		if !strings.Contains(body, "decoded size exceeds maximum allowed") {
-			t.Fatalf("expected error message about size limit, got: %s", body)
+		if !strings.Contains(body, "decoded size exceeds the") {
+			t.Fatalf("expected decoded size exceeds error, got: %s", body)
 		}
 	})