update phpstan to version 2 (#2046)

smhg · web-flow · commit a1fb067fea4e · 2025-06-17T17:37:08.000+02:00
* use deprecation rules to prepare for phpstan 2

* replace deprecated strftime

* remove obsolete statement

* remove wrong deprecation

The class XSLTProcessor is available in the PHP XSL extension

* ignore internal deprecations

* update phpstan to version 2

* regenerate phpstan baseline
diff --git a/composer.json b/composer.json
@@ -31,11 +31,13 @@
         "ext-json": "*",
         "ext-xml": "*",
         "monolog/monolog": "^1.3 || ^2.3 || ^3.0",
-        "phpstan/phpstan": "^1.2",
+        "phpstan/phpstan": "^2.0",
         "phpunit/phpunit": "^9.5.0",
         "spryker/code-sniffer": "^0.17.2",
         "psalm/phar": "^4.23",
-        "mikey179/vfsstream": "^1.6"
+        "mikey179/vfsstream": "^1.6",
+        "phpstan/phpstan-deprecation-rules": "^2.0",
+        "phpstan/extension-installer": "^1.4"
     },
     "suggest": {
         "monolog/monolog": "The recommended logging library to use with Propel."
@@ -72,7 +74,8 @@
     "config": {
         "process-timeout": 0,
         "allow-plugins": {
-            "dealerdirect/phpcodesniffer-composer-installer": true
+            "dealerdirect/phpcodesniffer-composer-installer": true,
+            "phpstan/extension-installer": true
         }
     }
 }
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
diff --git a/phpstan.neon b/phpstan.neon
@@ -10,4 +10,4 @@ parameters:
         - '#Call to an undefined method object::.+\(\)#'
         -
             identifier: missingType.iterableValue
-
+        - '#Call to deprecated method .* of class Propel\\#'
diff --git a/src/Propel/Generator/Builder/Om/ExtensionObjectBuilder.php b/src/Propel/Generator/Builder/Om/ExtensionObjectBuilder.php
@@ -50,7 +50,7 @@ protected function addClassOpen(string &$script): void
  * $tableDesc
  *";
             if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {
-                $now = strftime('%c');
+                $now = gmdate('c');
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:
  *
diff --git a/src/Propel/Generator/Builder/Om/ExtensionQueryBuilder.php b/src/Propel/Generator/Builder/Om/ExtensionQueryBuilder.php
@@ -51,7 +51,7 @@ protected function addClassOpen(string &$script): void
  * $tableDesc
  *";
             if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {
-                $now = strftime('%c');
+                $now = gmdate('c');
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:
  *
diff --git a/src/Propel/Generator/Builder/Om/ExtensionQueryInheritanceBuilder.php b/src/Propel/Generator/Builder/Om/ExtensionQueryInheritanceBuilder.php
@@ -101,7 +101,7 @@ protected function addClassOpen(string &$script): void
  * $tableDesc
  *";
             if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {
-                $now = strftime('%c');
+                $now = gmdate('c');
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:
  *
diff --git a/src/Propel/Generator/Builder/Om/InterfaceBuilder.php b/src/Propel/Generator/Builder/Om/InterfaceBuilder.php
@@ -48,7 +48,7 @@ protected function addClassOpen(string &$script): void
  * $tableDesc
  *";
         if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {
-            $now = strftime('%c');
+            $now = gmdate('c');
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:
  *
diff --git a/src/Propel/Generator/Builder/Om/MultiExtendObjectBuilder.php b/src/Propel/Generator/Builder/Om/MultiExtendObjectBuilder.php
@@ -133,7 +133,7 @@ protected function addClassOpen(string &$script): void
  * $tableDesc
  *";
             if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {
-                $now = strftime('%c');
+                $now = gmdate('c');
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:
  *
diff --git a/src/Propel/Generator/Builder/Om/ObjectBuilder.php b/src/Propel/Generator/Builder/Om/ObjectBuilder.php
@@ -256,7 +256,7 @@ protected function addClassOpen(string &$script): void
  * $tableDesc
  *";
             if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {
-                $now = strftime('%c');
+                $now = gmdate('c');
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:
  *
diff --git a/src/Propel/Generator/Builder/Om/QueryInheritanceBuilder.php b/src/Propel/Generator/Builder/Om/QueryInheritanceBuilder.php
@@ -142,7 +142,7 @@ protected function addClassOpen(string &$script): void
  * $tableDesc
  *";
         if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {
-            $now = strftime('%c');
+            $now = gmdate('c');
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:
  *
diff --git a/src/Propel/Generator/Builder/Om/TableMapBuilder.php b/src/Propel/Generator/Builder/Om/TableMapBuilder.php
@@ -82,7 +82,7 @@ protected function addClassOpen(string &$script): void
  *
  *";
         if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {
-            $now = strftime('%c');
+            $now = gmdate('c');
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:
  *
diff --git a/src/Propel/Generator/Builder/Util/SchemaReader.php b/src/Propel/Generator/Builder/Util/SchemaReader.php
@@ -185,7 +185,6 @@ public function parseString(string $xmlString, ?string $xmlFile = null): ?Schema
 
         $this->parser = xml_parser_create();
         xml_parser_set_option($this->parser, XML_OPTION_CASE_FOLDING, 0);
-        xml_set_object($this->parser, $this);
         xml_set_element_handler($this->parser, [$this, 'startElement'], [$this, 'endElement']);
         if (!xml_parse($this->parser, $xmlString)) {
             throw new SchemaException(
diff --git a/src/Propel/Generator/Manager/AbstractManager.php b/src/Propel/Generator/Manager/AbstractManager.php
@@ -24,6 +24,8 @@
  * An abstract base Propel manager to perform work related to the XML schema
  * file.
  *
+ * Requires PHP XSL extension for XSLT transformations.
+ *
  * @author Hans Lellelid <hans@xmpl.org> (Propel)
  * @author Jason van Zyl <jvanzyl@zenplex.com> (Torque)
  * @author Daniel Rall <dlr@finemaltcoding.com> (Torque)
@@ -76,8 +78,6 @@ abstract class AbstractManager
     /**
      * XSL file to use to normalize (or otherwise transform) schema before validation.
      *
-     * @deprecated Not in use and not working due to missing class.
-     *
      * @var mixed
      */
     protected $xsl;

Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,4 @@ parameters:`
`10`	`10`	`- '#Call to an undefined method object::.+\(\)#'`
`11`	`11`	`-`
`12`	`12`	`identifier: missingType.iterableValue`
`13`		`-`
	`13`	`+ - '#Call to deprecated method .* of class Propel\\#'`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ protected function addClassOpen(string &$script): void`
`50`	`50`	`* $tableDesc`
`51`	`51`	`*";`
`52`	`52`	`if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {`
`53`		`- $now = strftime('%c');`
	`53`	`+ $now = gmdate('c');`
`54`	`54`	`$script .= "`
`55`	`55`	`* This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:`
`56`	`56`	`*`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ protected function addClassOpen(string &$script): void`
`51`	`51`	`* $tableDesc`
`52`	`52`	`*";`
`53`	`53`	`if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {`
`54`		`- $now = strftime('%c');`
	`54`	`+ $now = gmdate('c');`
`55`	`55`	`$script .= "`
`56`	`56`	`* This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:`
`57`	`57`	`*`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ protected function addClassOpen(string &$script): void`
`101`	`101`	`* $tableDesc`
`102`	`102`	`*";`
`103`	`103`	`if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {`
`104`		`- $now = strftime('%c');`
	`104`	`+ $now = gmdate('c');`
`105`	`105`	`$script .= "`
`106`	`106`	`* This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:`
`107`	`107`	`*`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ protected function addClassOpen(string &$script): void`
`48`	`48`	`* $tableDesc`
`49`	`49`	`*";`
`50`	`50`	`if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {`
`51`		`- $now = strftime('%c');`
	`51`	`+ $now = gmdate('c');`
`52`	`52`	`$script .= "`
`53`	`53`	`* This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:`
`54`	`54`	`*`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ protected function addClassOpen(string &$script): void`
`133`	`133`	`* $tableDesc`
`134`	`134`	`*";`
`135`	`135`	`if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {`
`136`		`- $now = strftime('%c');`
	`136`	`+ $now = gmdate('c');`
`137`	`137`	`$script .= "`
`138`	`138`	`* This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:`
`139`	`139`	`*`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ protected function addClassOpen(string &$script): void`
`256`	`256`	`* $tableDesc`
`257`	`257`	`*";`
`258`	`258`	`if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {`
`259`		`- $now = strftime('%c');`
	`259`	`+ $now = gmdate('c');`
`260`	`260`	`$script .= "`
`261`	`261`	`* This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:`
`262`	`262`	`*`
Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ protected function addClassOpen(string &$script): void`
`142`	`142`	`* $tableDesc`
`143`	`143`	`*";`
`144`	`144`	`if ($this->getBuildProperty('generator.objectModel.addTimeStamp')) {`
`145`		`- $now = strftime('%c');`
	`145`	`+ $now = gmdate('c');`
`146`	`146`	`$script .= "`
`147`	`147`	`* This class was autogenerated by Propel " . $this->getBuildProperty('general.version') . " on:`
`148`	`148`	`*`