fix: add additional input validation

Signed-off-by: Matthew Penner <[email protected]>

Author: matthewpi

app/Http/Controllers/Base/LocaleController.php

@@ -2,11 +2,11 @@
 
 namespace Pterodactyl\Http\Controllers\Base;
 
-use Illuminate\Http\Request;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Translation\Translator;
 use Illuminate\Contracts\Translation\Loader;
 use Pterodactyl\Http\Controllers\Controller;
+use Pterodactyl\Http\Requests\Base\LocaleRequest;
 
 class LocaleController extends Controller
 {
@@ -20,20 +20,11 @@ public function __construct(Translator $translator)
     /**
      * Returns translation data given a specific locale and namespace.
      */
-    public function __invoke(Request $request): JsonResponse
+    public function __invoke(LocaleRequest $request): JsonResponse
     {
-        $locales = explode(' ', $request->input('locale') ?? '');
-        $namespaces = explode(' ', $request->input('namespace') ?? '');
-
-        $response = [];
-        foreach ($locales as $locale) {
-            $response[$locale] = [];
-            foreach ($namespaces as $namespace) {
-                $response[$locale][$namespace] = $this->i18n(
-                    $this->loader->load($locale, str_replace('.', '/', $namespace))
-                );
-            }
-        }
+        $locale = $request->input('locale');
+        $namespace = $request->input('namespace');
+        $response[$locale][$namespace] = $this->i18n($this->loader->load($locale, $namespace));
 
         return new JsonResponse($response, 200, [
             // Cache this in the browser for an hour, and allow the browser to use a stale

app/Http/Requests/Base/LocaleRequest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Pterodactyl\Http\Requests\Base;
+
+use Illuminate\Foundation\Http\FormRequest;
+
+class LocaleRequest extends FormRequest
+{
+    public function rules(): array
+    {
+        return [
+            'locale' => ['required', 'string', 'regex:/^[a-z][a-z]$/'],
+            'namespace' => ['required', 'string', 'regex:/^[a-z]{1,191}$/'],
+        ];
+    }
+}