Make the new tests more explicit

Author: jsignell

xarray/tests/test_dataarray.py

@@ -1703,9 +1703,18 @@ def should_add_coord_to_array(self, name, var, dims):
         assert "x_bnds" not in actual.dims
 
     def test_assign_coords_uses_base_variable_class(self) -> None:
-        a = DataArray([0, 1, 2], dims=["x"], coords={"x": [0, 1, 2]})
+        a = DataArray([0, 1, 3], dims=["x"], coords={"x": [0, 1, 2]})
         a = a.assign_coords(foo=a.x)
-        _assert_internal_invariants(a, check_default_indexes=True)
+
+        # explicit check
+        assert isinstance(a["x"].variable, IndexVariable)
+        assert not isinstance(a["foo"].variable, IndexVariable)
+
+        # test internal invariant checks when comparing the datasets
+        expected = DataArray(
+            [0, 1, 3], dims=["x"], coords={"x": [0, 1, 2], "foo": ("x", [0, 1, 2])}
+        )
+        assert_identical(a, expected)
 
     def test_coords_alignment(self) -> None:
         lhs = DataArray([1, 2, 3], [("x", [0, 1, 2])])

xarray/tests/test_dataset.py

@@ -4784,13 +4784,13 @@ def test_setitem_using_list_errors(self, var_list, data, error_regex) -> None:
     def test_setitem_uses_base_variable_class_even_for_index_variables(self) -> None:
         ds = Dataset(coords={"x": [1, 2, 3]})
         ds["y"] = ds["x"]
-        
+
         # explicit check
-        assert isintance(ds["x"].variable, IndexVariable)
+        assert isinstance(ds["x"].variable, IndexVariable)
         assert not isinstance(ds["y"].variable, IndexVariable)
-        
+
         # test internal invariant checks when comparing the datasets
-        expected = Dataset(coords={"x": [1, 2, 3], "y": ("x", [1, 2, 3])})
+        expected = Dataset(data_vars={"y": ("x", [1, 2, 3])}, coords={"x": [1, 2, 3]})
         assert_identical(ds, expected)
 
     def test_assign(self) -> None: