Tests: Open SVN dump file in binary mode to prevent UnicodeDecodeError

pareshjoshij · web-flow · commit f775e939f207 · 2025-11-27T12:23:43.000+05:30
The function `_create_svn_initools_repo` in `tests/lib/local_repos.py` was opening a downloaded SVN dump file using the default text mode (`'r'`).

Because SVN dump files contain binary data, this caused a `UnicodeDecodeError` on Windows and corrupted data due to newline translation when piping to `svnadmin`.

This commit changes the `open()` call to use `'rb'` (binary mode) to ensure the raw bytes are passed to `svnadmin` correctly.
diff --git a/tests/lib/local_repos.py b/tests/lib/local_repos.py
@@ -18,7 +18,7 @@ def _create_svn_initools_repo(initools_dir: str) -> None:
         "http://bitbucket.org/hltbra/pip-initools-dump/raw/8b55c908a320/"
         "INITools_modified.dump"
     )
-    with open(filename) as dump:
+    with open(filename, "rb") as dump:
         subprocess.check_call(
             ["svnadmin", "load", initools_dir],
             stdin=dump,

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ def _create_svn_initools_repo(initools_dir: str) -> None:`
`18`	`18`	`"http://bitbucket.org/hltbra/pip-initools-dump/raw/8b55c908a320/"`
`19`	`19`	`"INITools_modified.dump"`
`20`	`20`	`)`
`21`		`- with open(filename) as dump:`
	`21`	`+ with open(filename, "rb") as dump:`
`22`	`22`	`subprocess.check_call(`
`23`	`23`	`["svnadmin", "load", initools_dir],`
`24`	`24`	`stdin=dump,`