Fix index out of bounds panic when paired devices are removed #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When you unpair the last device and then try to cycle to the next device, here's what happens:
refresh()method updates the paired_devices vector with the new (shorter) listpaired_devices_stateselection index was never updated, so it could still point to an out-of-bounds indexcontroller.paired_devices[index]whereindexis out of bounds results in a panicI added bounds checking in the
refresh()method that:This is the same pattern already used for handling removed adapters but now applied to paired devices as well.