[BugFix] Use torch.zeros for argument in torch.where

[sebimarkgraf]

Description

This reorders the function calls to make the device lookup, right before usage.
Also, this uses torch.zeros_like as argument for the torch.where call instead
of relying on autocasting.

Motivation and Context

We are observing issues to export the module into ONNX on intel devices.
This seems to be due to the tracer having issues to match the inserted constant for the 0 to constant zero node autocast.

Error:

<class 'AssertionError'>: Expected same OpOverload packet, got prim.device != aten.where
While executing %where : [num_users=1] = call_function[target=torch.ops.aten.where.ScalarSelf](args = (%expand, %scalar_tensor_default, %unsqueeze_2), kwargs = {})

Interestingly this issue only appears intermittently, we believe due to our CI landing on intel cpus with specific features activated.
Therefore, a direct reproduction is hard to detail.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds core functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (update in the documentation)
• Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

• I have read the CONTRIBUTION guide (required)
• My change requires a change to the documentation.
• I have updated the tests accordingly (required for a bug fix or a new feature).
• I have updated the documentation accordingly.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3239

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Cancelled Job, 14 Unrelated Failures

As of commit be45894 with merge base 8570c25 ():

NEW FAILURES - The following jobs have failed:

• Continuous Benchmark (PR) / CPU Pytest benchmark (gh)
  Workflow failed! Resource not accessible by integration
• Habitat Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
  RuntimeError: Command docker exec -t 53cb0fbc59e7dfeece4f5a855c0487fd667c69bfcc96158db4bdffbbeef3a7da /exec failed with exit code 1
• Libs Tests on Linux / unittests-gym (3.9, 12.8) / linux-job (gh)
  RuntimeError: Command docker exec -t e60c16549effbe666f081728a68709cb77b881eb927e2befc8b64aba75f5f7e5 /exec failed with exit code 1
• Push Binary Nightly / build-wheel-unix (linux, ubuntu-22.04, 3.9, cp39-cp39, cpu, cpu) (gh)
• SOTA Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
  RuntimeError: Command docker exec -t 6c99282aea12b772a724a0590f728125b6adde9f654417e4849fa92737ccc28d /exec failed with exit code 1

CANCELLED JOB - The following job was cancelled. Please retry:

• Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
  ##[error]The operation was canceled.

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• Unit-tests on Linux / tests-gpu (3.11, 12.8) / linux-job (gh) (similar failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Push Binary Nightly / build-wheel-unix (macos, macos-latest, 3.9, cp39-cp39, cpu, cpu) (gh) (trunk failure)
  Process completed with exit code 1.
• Push Binary Nightly / build-wheel-windows (3.9, 3.9) (gh) (trunk failure)
  Process completed with exit code 1.
• Push Binary Nightly / test-wheel-unix (linux, ubuntu-22.04, 3.9, cp39-cp39, cpu, cpu) (gh) (trunk failure)
  Process completed with exit code 1.
• Push Binary Nightly / test-wheel-unix (macos, macos-latest, 3.9, cp39-cp39, cpu, cpu) (gh) (trunk failure)
  Process completed with exit code 1.
• Push Binary Nightly / test-wheel-windows (3.9, 3.9) (gh) (trunk failure)
  Process completed with exit code 1.
• Unit-tests on Linux / tests-cpu (3.10) / linux-job (gh) (trunk failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights
• Unit-tests on Linux / tests-cpu (3.11) / linux-job (gh) (trunk failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights
• Unit-tests on Linux / tests-cpu (3.12) / linux-job (gh) (trunk failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights
• Unit-tests on Linux / tests-cpu (3.9) / linux-job (gh) (trunk failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights
• Unit-tests on Linux / tests-olddeps (3.9, 11.6) / linux-job (gh) (trunk failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights
• Unit-tests on Linux / tests-optdeps (3.11, 12.8) / linux-job (gh) (trunk failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights
• Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job (gh) (trunk failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights
• Unit-tests on Windows / unittests-cpu (3.10, windows.4xlarge, cpu) / windows-job (gh) (trunk failure)
  test/test_cost.py::TestREDQ::test_sac_prioritized_weights

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[vmoens]

LGTM thanks