feat: Test object returned by dbUnquoteIdentifier() is of class Id
#404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #403
I haven't dived in to how unit testing is done for {DBItest}, any advice would be helpful. I searched for "quote" in the testthat/ folder with no hits, so I didn't see an easy way to shoehorn my way in.
I did notice this floating comment, it might be referring to the code in question?
DBItest/R/spec-sql-unquote-identifier.R
Lines 57 to 58 in f19fb4d
But if so, maybe it's outdated? Since as noted,
dbUnquoteIdentifier()is documented to returnId.This was added to {DBItest} (Mar. 2018) not long after
[Id]was documented as the return fordbUnquoteIdentifier()(Feb. 2018):r-dbi/DBI@8f2a2e9
e291f73