Skip to content

Conversation

@MichaelChirico
Copy link
Contributor

@MichaelChirico MichaelChirico commented Mar 18, 2025

Closes #403

I haven't dived in to how unit testing is done for {DBItest}, any advice would be helpful. I searched for "quote" in the testthat/ folder with no hits, so I didn't see an easy way to shoehorn my way in.

I did notice this floating comment, it might be referring to the code in question?

#' (For backends it may be most convenient to return [Id] objects
#' to achieve this behavior, but this is not required.)

But if so, maybe it's outdated? Since as noted, dbUnquoteIdentifier() is documented to return Id.

This was added to {DBItest} (Mar. 2018) not long after [Id] was documented as the return for dbUnquoteIdentifier() (Feb. 2018):

r-dbi/DBI@8f2a2e9

e291f73

@krlmlr krlmlr changed the title Test Id object is returned by dbUnquoteIdentifier feat: Test object returned by dbUnquoteIdentifier() is of class Id May 1, 2025
@krlmlr krlmlr merged commit 18af159 into r-dbi:main May 1, 2025
16 checks passed
@krlmlr
Copy link
Member

krlmlr commented May 1, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test that dbUnquoteIdentifer() return list(<Id>)?

2 participants