Skip to content

Commit 2cb4b85

Browse files
authored
Remove old vec_is_vector() callable (#2104)
* Remove old `vec_is_vector()` callable It has been a few years since we deprecated it in favor of `obj_is_vector()`. Only dplyr uses the `obj_is_vector()` callable. No one using `vec_is_vector()` now: https://github.com/search?q=org%3Acran+vec_is_vector+language%3Ac&type=code https://github.com/search?q=org%3Acran+vec_is_vector+language%3AC%2B%2B+&type=code * NEWS
1 parent 9a80368 commit 2cb4b85

File tree

4 files changed

+2
-15
lines changed

4 files changed

+2
-15
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# vctrs (development version)
22

3+
* The deprecated C callable for `vec_is_vector()` has been removed.
4+
35
* Fixed the C level signature for the `exp_short_init_compact_seq()` callable.
46

57
* Experimental "partial" type support has been removed. This idea never panned out and was not widely used. The following functions have been removed (#2101):

inst/include/vctrs.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,8 @@ bool (*obj_is_vector)(SEXP) = NULL;
55
R_len_t (*short_vec_size)(SEXP) = NULL;
66
SEXP (*short_vec_recycle)(SEXP, R_len_t) = NULL;
77

8-
// Deprecated
9-
bool (*vec_is_vector)(SEXP) = NULL;
10-
118
void vctrs_init_api(void) {
129
obj_is_vector = (bool (*)(SEXP)) R_GetCCallable("vctrs", "obj_is_vector");
1310
short_vec_size = (R_len_t (*)(SEXP)) R_GetCCallable("vctrs", "short_vec_size");
1411
short_vec_recycle = (SEXP (*)(SEXP, R_len_t)) R_GetCCallable("vctrs", "short_vec_recycle");
15-
16-
vec_is_vector = (bool (*)(SEXP)) R_GetCCallable("vctrs", "vec_is_vector");
1712
}

inst/include/vctrs.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@ extern bool (*obj_is_vector)(SEXP);
1010
extern R_len_t (*short_vec_size)(SEXP);
1111
extern SEXP (*short_vec_recycle)(SEXP, R_len_t);
1212

13-
// Deprecated in favor of `obj_is_vector()`
14-
// version: 0.5.3
15-
// date: 2023-02-15
16-
extern bool (*vec_is_vector)(SEXP);
17-
1813
void vctrs_init_api(void);
1914

2015
#endif

src/init.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -413,11 +413,6 @@ export void R_init_vctrs(DllInfo *dll)
413413
R_RegisterCCallable("vctrs", "short_vec_size", (DL_FUNC) &short_vec_size);
414414
R_RegisterCCallable("vctrs", "short_vec_recycle", (DL_FUNC) &short_vec_recycle);
415415

416-
// Deprecated
417-
// In the public header
418-
// See `inst/include/vctrs.h` for details
419-
R_RegisterCCallable("vctrs", "vec_is_vector", (DL_FUNC) &maturing_obj_is_vector);
420-
421416
// Experimental
422417
// Exported but not available in the public header
423418
R_RegisterCCallable("vctrs", "exp_vec_cast", (DL_FUNC) &exp_vec_cast);

0 commit comments

Comments
 (0)