fix: instantiating TwitterCardTags with image and no fallback image specified (#100)

* fix: Secure URL returning a URLGenerator when we expect a string

* WIP

* Update TwitterCardTagsTest.php

---------

Co-authored-by: Ralph J. Smit <[email protected]>

Author: SOD96

src/Tags/TwitterCardTags.php

@@ -19,7 +19,19 @@ public static function initialize(SEOData $SEOData): ?static
         $collection = new static;
 
         // No generic image that spans multiple pages
-        if ($SEOData->image && $SEOData->image !== secure_url(config('seo.image.fallback')) && $SEOData->imageMeta?->height > 0) {
+        $imageFallback = config('seo.image.fallback');
+
+        if (
+            $SEOData->image
+            && (
+                // If no fallback specified, then the image is not the fallback.
+                ! $imageFallback
+                // If fallback image specified, then verify if the image is not the fallback.
+                || $SEOData->image !== secure_url($imageFallback)
+            )
+            && $SEOData->imageMeta?->height !== null
+            && $SEOData->imageMeta->height > 0
+        ) {
             // Only one Twitter card can be pushed. The `summary_large_image` card
             // is tried first, then it falls back to the normal `summary` card.
             $imageMetaWidthDividedByHeight = $SEOData->imageMeta->width / $SEOData->imageMeta->height;

tests/Feature/Tags/TwitterCardTagsTest.php

@@ -0,0 +1,18 @@
+<?php
+
+use RalphJSmit\Laravel\SEO\Support\SEOData;
+use RalphJSmit\Laravel\SEO\Tags\TwitterCardTags;
+
+it('can instantiate the `TwitterCardTags` class when no fallback image has been specified in config', function () {
+    config()->set('seo.image.fallback', null);
+
+    $SEOData = new SEOData(
+        title: 'Unique Title',
+        image: '/default/image.jpg',
+    );
+
+    $twitterCardTags = TwitterCardTags::initialize($SEOData);
+
+    expect($twitterCardTags)
+        ->toBeInstanceOf(TwitterCardTags::class);
+});