Typescript definitions

[benoitgrelard]

Hi @rauschma, stumbled upon this little module today, super useful! I was doing concatenation using template strings but was having to escape etc, your module made everything even nicer so thanks for publishing it.

I am working with TypeScript and for now have created type definitions for re-template-tag locally in my project. I'd love to contribute and make them available for whoever uses your module.

Would you rather I:

• send a PR to this repo and have them bundled with your package?
  • pro: this is the preferred way as users are then not required to install them separately
  • con: can be sometimes a burden for the library author if they don't use TS themselves and don't want to maintain them
• send a PR to https://github.com/DefinitelyTyped/DefinitelyTyped and add the definitions there

Let me know!

Benoît ✌️

[benoitgrelard]

For info, this is what I have locally, I believe it matches your function signature, but do let me know if I missed something.

declare module 're-template-tag' {
	export function re(
		literals: TemplateStringsArray,
		...placeholders: Array<string | Regexp>
	): RegExp;
}

Cheers

[quanganhtran]

This issue's birthday is coming up. It would be nice if you would add the definition to DefinitelyTyped :D