Skip to content

Commit 460fb4c

Browse files
authored
perf: uninstall classnames, install clsx (#243)
* perf: uninstall classnames, install clsx * update snap
1 parent 6dafd0f commit 460fb4c

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ es
2828
coverage
2929
yarn.lock
3030
package-lock.json
31+
pnpm-lock.yaml
3132
.vscode
3233

3334
# dumi

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,17 @@
4646
"dependencies": {
4747
"@rc-component/trigger": "^3.0.0",
4848
"@rc-component/util": "^1.2.1",
49-
"classnames": "^2.2.6"
49+
"clsx": "^2.1.1"
5050
},
5151
"devDependencies": {
5252
"@rc-component/father-plugin": "^2.0.2",
53+
"@rc-component/menu": "^1.0.0",
5354
"@rc-component/np": "^1.0.3",
5455
"@rc-component/resize-observer": "^1.0.0",
5556
"@testing-library/jest-dom": "^5.16.5",
5657
"@testing-library/react": "^14.0.0",
57-
"@types/classnames": "^2.2.6",
5858
"@types/jest": "^29.0.0",
59+
"@types/node": "^24.5.2",
5960
"@types/react": "^18.0.0",
6061
"@types/react-dom": "^18.0.0",
6162
"@types/warning": "^3.0.0",
@@ -71,7 +72,6 @@
7172
"less": "^4.1.1",
7273
"lint-staged": "^13.2.1",
7374
"prettier": "^2.8.7",
74-
"@rc-component/menu": "^1.0.0",
7575
"rc-test": "^7.0.14",
7676
"react": "^18.0.0",
7777
"react-dom": "^18.0.0",

src/Dropdown.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import type {
77
BuildInPlacements,
88
} from '@rc-component/trigger/lib/interface';
99
import { composeRef, getNodeRef, supportRef } from '@rc-component/util/lib/ref';
10-
import classNames from 'classnames';
10+
import { clsx } from 'clsx';
1111
import React from 'react';
1212
import useAccessibility from './hooks/useAccessibility';
1313
import Overlay from './Overlay';
@@ -136,7 +136,7 @@ function Dropdown(props: DropdownProps, ref) {
136136
};
137137

138138
const childrenNode = React.cloneElement(children, {
139-
className: classNames(
139+
className: clsx(
140140
children.props?.className,
141141
mergedVisible && getOpenClassName(),
142142
),
@@ -156,7 +156,7 @@ function Dropdown(props: DropdownProps, ref) {
156156
{...otherProps}
157157
prefixCls={prefixCls}
158158
ref={triggerRef}
159-
popupClassName={classNames(overlayClassName, {
159+
popupClassName={clsx(overlayClassName, {
160160
[`${prefixCls}-show-arrow`]: arrow,
161161
})}
162162
popupStyle={overlayStyle}

tests/__snapshots__/basic.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ exports[`dropdown simply works 1`] = `
2020
>
2121
<li
2222
class="rc-menu-item"
23-
data-menu-id="rc-menu-uuid-test-1"
23+
data-menu-id="rc-menu-uuid-1"
2424
role="menuitem"
2525
tabindex="-1"
2626
>
@@ -36,7 +36,7 @@ exports[`dropdown simply works 1`] = `
3636
/>
3737
<li
3838
class="rc-menu-item"
39-
data-menu-id="rc-menu-uuid-test-2"
39+
data-menu-id="rc-menu-uuid-2"
4040
role="menuitem"
4141
tabindex="-1"
4242
>

0 commit comments

Comments
 (0)