Skip to content

Commit 48c33b3

Browse files
committed
fix: 去掉没有必要的 useCallback
1 parent 169288c commit 48c33b3

File tree

2 files changed

+11
-16
lines changed

2 files changed

+11
-16
lines changed

src/Filler.tsx

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,15 @@ const Filler = React.forwardRef(
6969
};
7070
}
7171

72-
const handleResize = React.useCallback(
73-
({ offsetHeight }) => {
74-
if (offsetHeight && onInnerResize) {
75-
onInnerResize();
76-
}
77-
},
78-
[onInnerResize],
79-
);
72+
const handleResize = ({ offsetHeight }) => {
73+
if (offsetHeight && onInnerResize) {
74+
onInnerResize();
75+
}
76+
};
8077

8178
return (
8279
<div style={outerStyle}>
83-
<ResizeObserver
84-
onResize={handleResize}
85-
>
80+
<ResizeObserver onResize={handleResize}>
8681
<div
8782
style={innerStyle}
8883
className={classNames({

src/hooks/useHeights.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ export default function useHeights<T>(
2424

2525
const promiseIdRef = useRef<number>(0);
2626

27-
const cancelRaf = React.useCallback(function cancelRaf() {
27+
function cancelRaf() {
2828
promiseIdRef.current += 1;
29-
}, []);
29+
}
3030

31-
const collectHeight = React.useCallback(function (sync = false) {
31+
function collectHeight(sync = false) {
3232
cancelRaf();
3333

3434
const doCollect = () => {
@@ -67,7 +67,7 @@ export default function useHeights<T>(
6767
}
6868
});
6969
}
70-
}, [cancelRaf]);
70+
}
7171

7272
const setInstanceRef = React.useCallback(function setInstanceRef(item: T, instance: HTMLElement) {
7373
const key = getKey(item);
@@ -88,7 +88,7 @@ export default function useHeights<T>(
8888
onItemRemove?.(item);
8989
}
9090
}
91-
}, [collectHeight, getKey, onItemAdd, onItemRemove]);
91+
}, [getKey, onItemAdd, onItemRemove]);
9292

9393
useEffect(() => {
9494
return cancelRaf;

0 commit comments

Comments
 (0)