feat:separate episode label from title & setting for it #2093
Conversation
rockhero1234
changed the title
| if (card.type?.isMovieType() == false && showEpisodeLabel) { | ||
| val context = cardText?.context | ||
| val text = when { | ||
| showTitle -> context?.getNameFull(card.name, card.episode, card.season) |
There was a problem hiding this comment.
I do not understand this line? If you disable title but enable episode label it looks very weird with no labels on movies but labels on tv-series. Futhermore this breaks the UI as it will push the UI up and down moving everything, if you have mixed set of both movies and tv-series.
There was a problem hiding this comment.
I tested working fine for me
There was a problem hiding this comment.
In your continue watching have a row like this where you only have 3~4 items visible at the same time.
"MMMMMEEEEEEMEMEMEMEE" where M = Movie and E = Episode. If you only have movies then it is hidden, but as soon as you scroll to episodes it pops in and moves the entire layout down due to wrap_content. Moving layouts after inflating it is a no-go for UX, and is only done in Cloudstream when it is really needed.
2 participants
No description provided.