Updated Rector to commit 21b60910ad5526c24c3b812c7dec754e1be9ef52

rectorphp/rector-src@21b6091 [CodeQuality] Handle property fetch and common nodes crash on InlineArrayReturnAssignRector (#7437)

Author: TomasVotruba

rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php

@@ -45,7 +45,8 @@ public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedO
         $namespace = $scope instanceof Scope ? $scope->getNamespace() : null;
         $namespace = strtolower((string) $namespace);
         $shortNameLowered = $fullyQualifiedObjectType->getShortNameLowered();
-        $fullyQualifiedObjectTypeNamespace = strtolower(substr($fullyQualifiedObjectType->getClassName(), 0, -strlen($fullyQualifiedObjectType->getShortName()) - 1) ?: '');
+        $subClassName = substr($fullyQualifiedObjectType->getClassName(), 0, -strlen($fullyQualifiedObjectType->getShortName()) - 1);
+        $fullyQualifiedObjectTypeNamespace = strtolower((string) $subClassName);
         foreach ($classLikeNames as $classLikeName) {
             if (strtolower($classLikeName) !== $shortNameLowered) {
                 continue;

src/Application/VersionResolver.php

@@ -19,12 +19,12 @@ final class VersionResolver
      * @api
      * @var string
      */
-    public const PACKAGE_VERSION = '24b76ca1eead8bb095d9dd769a5ace4dfde79915';
+    public const PACKAGE_VERSION = '21b60910ad5526c24c3b812c7dec754e1be9ef52';
     /**
      * @api
      * @var string
      */
-    public const RELEASE_DATE = '2025-10-06 20:29:26';
+    public const RELEASE_DATE = '2025-10-07 04:09:59';
     /**
      * @var int
      */

src/PhpParser/Node/NodeFactory.php

@@ -22,10 +22,14 @@
 use PhpParser\Node\Expr\BinaryOp\NotIdentical;
 use PhpParser\Node\Expr\Cast;
 use PhpParser\Node\Expr\ClassConstFetch;
+use PhpParser\Node\Expr\Clone_;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Expr\Instanceof_;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\New_;
+use PhpParser\Node\Expr\NullsafeMethodCall;
+use PhpParser\Node\Expr\NullsafePropertyFetch;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\StaticPropertyFetch;
@@ -43,7 +47,6 @@
 use PHPStan\Type\Type;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\Enum\ObjectReference;
-use Rector\Exception\NotImplementedYetException;
 use Rector\Exception\ShouldNotHappenException;
 use Rector\NodeDecorator\PropertyTypeDecorator;
 use Rector\NodeTypeResolver\Node\AttributeKey;
@@ -346,7 +349,7 @@ public function createReprintedNode(Node $node): Node
     private function createArrayItem($item, $key = null): ArrayItem
     {
         $arrayItem = null;
-        if ($item instanceof Variable || $item instanceof MethodCall || $item instanceof StaticCall || $item instanceof FuncCall || $item instanceof Concat || $item instanceof Scalar || $item instanceof Cast || $item instanceof ConstFetch) {
+        if ($item instanceof Variable || $item instanceof MethodCall || $item instanceof StaticCall || $item instanceof FuncCall || $item instanceof Concat || $item instanceof Scalar || $item instanceof Cast || $item instanceof ConstFetch || $item instanceof PropertyFetch || $item instanceof StaticPropertyFetch || $item instanceof NullsafePropertyFetch || $item instanceof NullsafeMethodCall || $item instanceof Clone_ || $item instanceof Instanceof_) {
             $arrayItem = new ArrayItem($item);
         } elseif ($item instanceof Identifier) {
             $string = new String_($item->toString());
@@ -376,8 +379,16 @@ private function createArrayItem($item, $key = null): ArrayItem
             $this->decorateArrayItemWithKey($key, $arrayItem);
             return $arrayItem;
         }
-        $nodeClass = is_object($item) ? get_class($item) : $item;
-        throw new NotImplementedYetException(sprintf('Not implemented yet. Go to "%s()" and add check for "%s" node.', __METHOD__, (string) $nodeClass));
+        // fallback to other nodes
+        if ($item instanceof Expr) {
+            $arrayItem = new ArrayItem($item);
+            $this->decorateArrayItemWithKey($key, $arrayItem);
+            return $arrayItem;
+        }
+        $itemValue = BuilderHelpers::normalizeValue($item);
+        $arrayItem = new ArrayItem($itemValue);
+        $this->decorateArrayItemWithKey($key, $arrayItem);
+        return $arrayItem;
     }
     /**
      * @param int|string|null $key