Skip to content

Commit bb98ddc

Browse files
committed
chore: always display the last item in logger if the number of arguments is odd.
1 parent cd57986 commit bb98ddc

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

logging/legacy.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,13 @@ func (l *legacyLoggerAdapter) structuredToPrintf(msg string, v ...any) (string,
1818
var args []any
1919

2020
for i := 0; i < len(v); i += 2 {
21+
format += " %v=%v"
2122
if i+1 >= len(v) {
23+
// Odd number of arguments, append a placeholder for the missing value
24+
// adapted from https://cs.opensource.google/go/go/+/master:src/log/slog/record.go;l=160-182;drc=8c41a482f9b7a101404cd0b417ac45abd441e598
25+
args = append(args, "!BADKEY", v[i])
2226
break
2327
}
24-
format += " %v=%v"
2528
args = append(args, v[i], v[i+1])
2629
}
2730

0 commit comments

Comments
 (0)