Skip to content

Conversation

@rtomas
Copy link
Contributor

@rtomas rtomas commented Oct 24, 2025

Description

Add expiry to Universal Connector

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@rtomas rtomas requested a review from tomiir October 24, 2025 13:23
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

⚠️ No Changeset found

Latest commit: 632a5bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Oct 24, 2025 1:24pm
appkit-demo Ready Ready Preview Comment Oct 24, 2025 1:24pm
appkit-gallery Ready Ready Preview Comment Oct 24, 2025 1:24pm
appkit-laboratory Ready Ready Preview Comment Oct 24, 2025 1:24pm
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Oct 24, 2025 1:24pm
appkit-basic-sign-client-example Ignored Ignored Oct 24, 2025 1:24pm
appkit-basic-up-example Ignored Ignored Oct 24, 2025 1:24pm
appkit-ethers5-bera Ignored Ignored Oct 24, 2025 1:24pm
appkit-nansen-demo Ignored Ignored Oct 24, 2025 1:24pm
appkit-vue-solana Ignored Ignored Oct 24, 2025 1:24pm
appkit-wagmi-cdn-example Ignored Ignored Oct 24, 2025 1:24pm
ethereum-provider-wagmi-example Ignored Ignored Oct 24, 2025 1:24pm
next-wagmi-solana-bitcoin-example Ignored Ignored Oct 24, 2025 1:24pm
vue-wagmi-example Ignored Ignored Oct 24, 2025 1:24pm

@github-actions
Copy link
Contributor

Visual Regression Test Results ✅ Passed

✨ No visual changes detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=232
Storybook Preview: https://6493191bf4b10fed8ca7353f-emyrfwqhak.chromatic.com/

@github-actions
Copy link
Contributor

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         70.43 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 396 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit/react
Size limit:   230 kB
Size:         225.83 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 888 ms    on Snapdragon 410
Total time:   5.3 s
@reown/appkit/vue
Size limit:   80 kB
Size:         70.43 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 272 ms   on Snapdragon 410
Total time:   1.7 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         206.11 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 480 ms    on Snapdragon 410
Total time:   4.6 s
@reown/appkit-ui
Size limit:   500 kB
Size:         12.99 kB with all dependencies, minified and gzipped
Loading time: 254 ms   on slow 3G
Running time: 67 ms    on Snapdragon 410
Total time:   321 ms

@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.85% 36706 / 45967
🔵 Statements 79.85% 36706 / 45967
🔵 Functions 78.13% 4017 / 5141
🔵 Branches 86.35% 8807 / 10199
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/universal-connector/src/UniversalConnector.ts 100% 57.89% 100% 100%
Generated in workflow #16062 for commit 632a5bc by the Vitest Coverage Report Action

projectId: config.projectId,
metadata: config.metadata
metadata: config.metadata,
...(config.expiry ? { expiry: config.expiry } : {})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
...(config.expiry ? { expiry: config.expiry } : {})
expiry: config.expiry

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not do it like this? or set a default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you wanted to set the default at a lower level and make it optional here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also to have backwards compatibility ... but we can add a default if you think it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants