Skip to content

Conversation

@jprochazk
Copy link
Member

@jprochazk jprochazk commented Nov 21, 2024

What

  • Greatly simplify the PR template
  • Nuke PR summary
  • Simplify paths-filter in PR CI, so that we don't start N machines for N filters
  • Checkboxes in PR body are now optional, but still checked if present
  • Web build status comment
  • First-time contributor comments
  • Add an index page to https://build.rerun.io
  • 👽

@jprochazk jprochazk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Nov 21, 2024
@github-actions
Copy link

github-actions bot commented Nov 21, 2024

Latest documentation preview failed to deploy, check the CI for more details:
https://github.com/rerun-io/rerun/actions/runs/11957158020?pr=8192

Result Commit Link
unavailable

Note: This comment is updated whenever you push a commit.

@github-actions
Copy link

github-actions bot commented Nov 21, 2024

Web viewer failed to build.

Result Commit Link
https://rerun.io/viewer/pr/8192

Note: This comment is updated whenever you push a commit.

@jprochazk jprochazk changed the title New PR template + CI updates New PR template + associated CI updates Nov 21, 2024
@jprochazk
Copy link
Member Author

CLA tested here (thanks Moritz!): jprochazk/ci-playground#9

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! ⭐

@jprochazk jprochazk merged commit 240033f into main Nov 21, 2024
6 checks passed
@jprochazk jprochazk deleted the jan/new-pr-template branch November 21, 2024 16:10
@Wumpf
Copy link
Member

Wumpf commented Nov 21, 2024

<3

@jprochazk
Copy link
Member Author

👀 @Wumpf https://www.notion.so/rerunio/PR-templates-associated-CI-steps-143b24554b1980b0ac7ef62124c0a529?pvs=4#143b24554b198093bd32f991c31c8266

@Wumpf Wumpf mentioned this pull request Nov 22, 2024
Wumpf added a commit that referenced this pull request Nov 25, 2024
### Related

* Follow-up to #8192

### What

* move some stuff in we had previously on pr template
* shorten & update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants