File tree Expand file tree Collapse file tree 2 files changed +9
-1
lines changed Expand file tree Collapse file tree 2 files changed +9
-1
lines changed Original file line number Diff line number Diff line change 1010> - :house : [ Internal]
1111> - :nail_care : [ Polish]
1212
13+ ## [ Unreleased]
14+
15+ #### :nail_care : Polish
16+
17+ - Resolve symlinks when finding platform binaries. https://github.com/rescript-lang/rescript-vscode/pull/1154
18+
1319## 1.70.0
1420
1521#### :bug : Bug fix
Original file line number Diff line number Diff line change @@ -145,8 +145,10 @@ let findBinary = async (
145145 // TODO: export `binPaths` from `rescript` package so that we don't need to
146146 // copy the logic for figuring out `target`.
147147 const target = `${ process . platform } -${ process . arch } ` ;
148+ // Use realpathSync to resolve symlinks, which is necessary for package
149+ // managers like Deno and pnpm that use symlinked node_modules structures.
148150 const targetPackagePath = path . join (
149- rescriptDir ,
151+ fs . realpathSync ( rescriptDir ) ,
150152 ".." ,
151153 `@rescript/${ target } /bin.js` ,
152154 ) ;
You can’t perform that action at this time.
0 commit comments