Change all octothorpes # to _ since private # is only >=ES2022 (#1319)

Author: matux

src/browser/replay/recorder.js

@@ -5,11 +5,11 @@ import hrtime from '../../tracing/hrtime.js';
 import logger from '../logger.js';
 
 export default class Recorder {
-  #options;
-  #rrwebOptions;
-  #stopFn = null;
-  #recordFn;
-  #events = {
+  _options;
+  _rrwebOptions;
+  _stopFn = null;
+  _recordFn;
+  _events = {
     previous: [],
     current: [],
   };
@@ -26,15 +26,15 @@ export default class Recorder {
     }
 
     this.options = options;
-    this.#recordFn = recordFn;
+    this._recordFn = recordFn;
   }
 
   get isRecording() {
-    return this.#stopFn !== null;
+    return this._stopFn !== null;
   }
 
   get options() {
-    return this.#options;
+    return this._options;
   }
 
   set options(newOptions) {
@@ -57,8 +57,8 @@ export default class Recorder {
       // rrweb options
       ...rrwebOptions
     } = newOptions;
-    this.#options = { enabled, autoStart, maxSeconds, triggers, debug };
-    this.#rrwebOptions = rrwebOptions;
+    this._options = { enabled, autoStart, maxSeconds, triggers, debug };
+    this._rrwebOptions = rrwebOptions;
 
     if (this.isRecording && newOptions.enabled === false) {
       this.stop();
@@ -83,7 +83,7 @@ export default class Recorder {
    * @returns {Object|null} A formatted payload containing spans data in OTLP format, or null if no events exist
    */
   dump(tracing, replayId, occurrenceUuid) {
-    const events = this.#events.previous.concat(this.#events.current);
+    const events = this._events.previous.concat(this._events.current);
 
     if (events.length < 2) {
       logger.error('Replay recording cannot have less than 2 events');
@@ -132,18 +132,18 @@ export default class Recorder {
 
     this.clear();
 
-    this.#stopFn = this.#recordFn({
+    this._stopFn = this._recordFn({
       emit: (event, isCheckout) => {
         if (this.options.debug?.logEmits) {
           this._logEvent(event, isCheckout);
         }
 
         if (isCheckout && event.type === EventType.Meta) {
-          this.#events.previous = this.#events.current;
-          this.#events.current = [];
+          this._events.previous = this._events.current;
+          this._events.current = [];
         }
 
-        this.#events.current.push(event);
+        this._events.current.push(event);
       },
       checkoutEveryNms: this.checkoutEveryNms(),
       errorHandler: (error) => {
@@ -152,7 +152,7 @@ export default class Recorder {
         }
         return true; // swallow the error instead of throwing it to the window
       },
-      ...this.#rrwebOptions,
+      ...this._rrwebOptions,
     });
 
     return this;
@@ -163,14 +163,14 @@ export default class Recorder {
       return;
     }
 
-    this.#stopFn();
-    this.#stopFn = null;
+    this._stopFn();
+    this._stopFn = null;
 
     return this;
   }
 
   clear() {
-    this.#events = {
+    this._events = {
       previous: [],
       current: [],
     };

src/browser/replay/replayManager.js

@@ -7,11 +7,11 @@ import logger from '../logger.js';
  * are dumped and when they are eventually sent to the backend.
  */
 export default class ReplayManager {
-  #map;
-  #recorder;
-  #api;
-  #tracing;
-  #telemeter;
+  _map;
+  _recorder;
+  _api;
+  _tracing;
+  _telemeter;
 
   /**
    * Creates a new ReplayManager instance
@@ -34,11 +34,11 @@ export default class ReplayManager {
       throw new TypeError("Expected 'tracing' to be provided");
     }
 
-    this.#map = new Map();
-    this.#recorder = recorder;
-    this.#api = api;
-    this.#tracing = tracing;
-    this.#telemeter = telemeter;
+    this._map = new Map();
+    this._recorder = recorder;
+    this._api = api;
+    this._tracing = tracing;
+    this._telemeter = telemeter;
   }
 
   /**
@@ -53,19 +53,19 @@ export default class ReplayManager {
    */
   async _processReplay(replayId, occurrenceUuid) {
     try {
-      this.#telemeter?.exportTelemetrySpan({ 'rollbar.replay.id': replayId });
+      this._telemeter?.exportTelemetrySpan({ 'rollbar.replay.id': replayId });
 
-      const payload = this.#recorder.dump(
-        this.#tracing,
+      const payload = this._recorder.dump(
+        this._tracing,
         replayId,
         occurrenceUuid,
       );
 
-      this.#map.set(replayId, payload);
+      this._map.set(replayId, payload);
     } catch (transformError) {
       logger.error('Error transforming spans:', transformError);
 
-      this.#map.set(replayId, null); // TODO(matux): Error span?
+      this._map.set(replayId, null); // TODO(matux): Error span?
     }
 
     return replayId;
@@ -107,15 +107,15 @@ export default class ReplayManager {
       return false;
     }
 
-    if (!this.#map.has(replayId)) {
+    if (!this._map.has(replayId)) {
       logger.error(
         `ReplayManager.send: No replay found for replayId: ${replayId}`,
       );
       return false;
     }
 
-    const payload = this.#map.get(replayId);
-    this.#map.delete(replayId);
+    const payload = this._map.get(replayId);
+    this._map.delete(replayId);
 
     // Check if payload is empty (could be raw spans array or OTLP payload)
     const isEmpty =
@@ -131,7 +131,7 @@ export default class ReplayManager {
     }
 
     try {
-      await this.#api.postSpans(payload, { 'X-Rollbar-Replay-Id': replayId });
+      await this._api.postSpans(payload, { 'X-Rollbar-Replay-Id': replayId });
       return true;
     } catch (error) {
       logger.error('Error sending replay:', error);
@@ -152,14 +152,14 @@ export default class ReplayManager {
       return false;
     }
 
-    if (!this.#map.has(replayId)) {
+    if (!this._map.has(replayId)) {
       logger.error(
         `ReplayManager.discard: No replay found for replayId: ${replayId}`,
       );
       return false;
     }
 
-    this.#map.delete(replayId);
+    this._map.delete(replayId);
     return true;
   }
 
@@ -170,7 +170,7 @@ export default class ReplayManager {
    * @returns {Array|null} The spans array or null if not found
    */
   getSpans(replayId) {
-    return this.#map.get(replayId) ?? null;
+    return this._map.get(replayId) ?? null;
   }
 
   /**
@@ -180,7 +180,7 @@ export default class ReplayManager {
    * @param {Array} spans - The spans to set
    */
   setSpans(replayId, spans) {
-    this.#map.set(replayId, spans);
+    this._map.set(replayId, spans);
   }
 
   /**
@@ -189,13 +189,13 @@ export default class ReplayManager {
    * @returns {number} The number of replays currently stored
    */
   get size() {
-    return this.#map.size;
+    return this._map.size;
   }
 
   /**
    * Clears all stored replays without sending them
    */
   clear() {
-    this.#map.clear();
+    this._map.clear();
   }
 }

src/telemetry.js

@@ -273,9 +273,9 @@ class Telemeter {
       value,
       endTimeUnixNano: fromMillis(timestamp),
     };
-    const event = this.#getRepeatedEvent(name, otelAttributes);
+    const event = this._getRepeatedEvent(name, otelAttributes);
     if (event) {
-      return this.#updateRepeatedEvent(event, otelAttributes, timestamp);
+      return this._updateRepeatedEvent(event, otelAttributes, timestamp);
     }
 
     this.telemetrySpan?.addEvent(
@@ -312,9 +312,9 @@ class Telemeter {
       element,
       endTimeUnixNano: fromMillis(timestamp),
     };
-    const event = this.#getRepeatedEvent(name, otelAttributes);
+    const event = this._getRepeatedEvent(name, otelAttributes);
     if (event) {
-      return this.#updateRepeatedEvent(event, otelAttributes, timestamp);
+      return this._updateRepeatedEvent(event, otelAttributes, timestamp);
     }
 
     this.telemetrySpan?.addEvent(
@@ -333,15 +333,15 @@ class Telemeter {
     );
   }
 
-  #getRepeatedEvent(name, attributes) {
-    const lastEvent = this.#lastEvent(this.queue);
+  _getRepeatedEvent(name, attributes) {
+    const lastEvent = this._lastEvent(this.queue);
 
     if (lastEvent && lastEvent.body.type === name && lastEvent.otelAttributes.target === attributes.target) {
       return lastEvent;
     }
   }
 
-  #updateRepeatedEvent(event, attributes, timestamp) {
+  _updateRepeatedEvent(event, attributes, timestamp) {
     const duration = Math.max(timestamp - event.timestamp_ms, 1);
     event.body.value = attributes.value;
     event.otelAttributes.value = attributes.value;
@@ -354,7 +354,7 @@ class Telemeter {
     event.otelAttributes.ratio = event.otelAttributes.count / (duration / 1000);
   }
 
-  #lastEvent(list) {
+  _lastEvent(list) {
     return list.length > 0 ? list[list.length - 1] : null;
   }
 
@@ -416,9 +416,9 @@ class Telemeter {
       textZoomRatio,
     };
 
-    const event = this.#getRepeatedEvent(name, otelAttributes);
+    const event = this._getRepeatedEvent(name, otelAttributes);
     if (event) {
-      return this.#updateRepeatedEvent(event, otelAttributes, timestamp);
+      return this._updateRepeatedEvent(event, otelAttributes, timestamp);
     }
 
     this.telemetrySpan?.addEvent(

src/tracing/session.js

@@ -3,14 +3,14 @@ import id from './id.js';
 const SESSION_KEY = 'RollbarSession';
 
 export class Session {
-  #attributes;
+  _attributes;
 
   constructor(tracing, options) {
     this.options = options;
     this.tracing = tracing;
     this.window = tracing.window;
     this.session = null;
-    this.#attributes = {};
+    this._attributes = {};
   }
 
   init() {
@@ -56,11 +56,11 @@ export class Session {
   }
 
   get attributes() {
-    return this.#attributes;
+    return this._attributes;
   }
 
   setAttributes(attributes) {
-    this.#attributes = { ...this.#attributes, ...attributes };
+    this._attributes = { ...this._attributes, ...attributes };
     return this;
   }
 }