feat: migrate to nodejs 22 and remove unused code (#2703)

apalchys · web-flow · commit 179e6d823945 · 2025-05-11T19:45:23.000+02:00
diff --git a/.github/workflows/deploy-sloths.yaml b/.github/workflows/deploy-sloths.yaml
@@ -21,7 +21,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml
@@ -18,7 +18,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
@@ -104,7 +104,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
@@ -165,7 +165,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
@@ -40,7 +40,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
@@ -90,7 +90,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
@@ -243,7 +243,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
@@ -297,7 +297,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Restore npm cache
         uses: actions/cache@v4
diff --git a/.github/workflows/pull_request_close.yml b/.github/workflows/pull_request_close.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Setup Node.js environment
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
 
       - name: Checkout
         uses: actions/checkout@v4
diff --git a/client/Dockerfile.lambda b/client/Dockerfile.lambda
@@ -1,4 +1,4 @@
-FROM node:20-bullseye-slim as builder
+FROM node:22-bullseye-slim as builder
 
 ENV NEXT_RUNTIME nodejs
 
@@ -18,7 +18,7 @@ COPY client/dist client/
 COPY client/.next client/.next
 
 # Lambda Container
-FROM public.ecr.aws/lambda/nodejs:20
+FROM public.ecr.aws/lambda/nodejs:22
 
 ENV NODE_ENV production
 ENV TZ utc
diff --git a/nestjs/Dockerfile b/nestjs/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:20-alpine
+FROM node:22-alpine
 
 EXPOSE 8080
 
diff --git a/nestjs/Dockerfile.lambda b/nestjs/Dockerfile.lambda
@@ -1,4 +1,4 @@
-FROM node:20-bullseye-slim as builder
+FROM node:22-bullseye-slim as builder
 
 WORKDIR /container_out
 
@@ -13,7 +13,7 @@ COPY nestjs/lambda nestjs/
 COPY nestjs/dist nestjs/
 
 # Lambda Container
-FROM public.ecr.aws/lambda/nodejs:20
+FROM public.ecr.aws/lambda/nodejs:22
 
 ENV NODE_ENV production
 ENV TZ utc
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -8,7 +8,7 @@
     "client"
   ],
   "engines": {
-    "node": ">=20",
+    "node": ">=22",
     "npm": ">=10"
   },
   "scripts": {
diff --git a/server/Dockerfile.lambda b/server/Dockerfile.lambda
@@ -1,4 +1,4 @@
-FROM node:20-bullseye-slim as builder
+FROM node:22-bullseye-slim as builder
 
 WORKDIR /container_out
 
@@ -14,7 +14,7 @@ COPY server/lambda server/
 COPY server/dist server/
 
 # Lambda Container
-FROM public.ecr.aws/lambda/nodejs:20
+FROM public.ecr.aws/lambda/nodejs:22
 
 ENV NODE_ENV production
 ENV TZ utc
diff --git a/server/src/routes/activity/index.ts b/server/src/routes/activity/index.ts
diff --git a/server/src/routes/index.ts b/server/src/routes/index.ts
@@ -1,6 +1,5 @@
 import Router from '@koa/router';
 
-import { activityRoute } from './activity';
 import { courseRoute } from './course';
 import { feedbackRoute } from './feedback';
 import { filesRoute } from './file';
@@ -9,9 +8,7 @@ import { publicMeRouter } from './me';
 import { profileRoute } from './profile';
 import { registryRouter } from './registry';
 import { repositoryRoute } from './repository';
-import { studentRoute } from './student';
 import { taskRoute } from './task';
-import { taskResultRoute } from './taskResult';
 import { tasksRoute } from './tasks';
 import { taskVerification } from './taskVerification';
 import { usersRoute } from './users';
@@ -42,12 +39,9 @@ export const routesMiddleware: RoutesMiddleware = (logger: ILogger) => {
   applyRouter(router, courseRoute(logger));
   applyRouter(router, usersRoute(logger));
   applyRouter(router, taskRoute(logger));
-  applyRouter(router, taskResultRoute(logger));
-  applyRouter(router, studentRoute(logger));
   applyRouter(router, tasksRoute(logger));
   applyRouter(router, taskVerification(logger));
   applyRouter(router, profileRoute(logger));
-  applyRouter(router, activityRoute(logger));
   applyRouter(router, feedbackRoute(logger));
   applyRouter(router, checksRoute(logger));
   applyRouter(router, filesRoute(logger));
diff --git a/server/src/routes/student/index.ts b/server/src/routes/student/index.ts
diff --git a/server/src/routes/task/index.ts b/server/src/routes/task/index.ts
@@ -1,12 +1,12 @@
-import { BAD_REQUEST, OK } from 'http-status-codes';
 import Router from '@koa/router';
-import { ILogger } from '../../logger';
-import { Task, TaskVerification } from '../../models';
-import { createGetRoute, createPostRoute, createPutRoute } from '../common';
-import { guard, anyCourseManagerGuard, adminGuard, basicAuthAws } from '../guards';
-import { setResponse } from '../utils';
+import { BAD_REQUEST, OK } from 'http-status-codes';
 import { getRepository } from 'typeorm';
+import { ILogger } from '../../logger';
+import { TaskVerification } from '../../models';
 import { ScoreService } from '../../services/score';
+import { createPostRoute } from '../common';
+import { adminGuard, basicAuthAws } from '../guards';
+import { setResponse } from '../utils';
 
 const validateTaskId = async (ctx: Router.RouterContext, next: any) => {
   const id = Number(ctx.params.id);
@@ -54,9 +54,5 @@ export function taskRoute(logger: ILogger) {
   router.post('/verification', adminGuard, createPostRoute(TaskVerification, logger));
   router.put('/verification/:id', basicAuthAws, validateTaskId, updateVerification(logger));
 
-  router.get('/:id', guard, createGetRoute(Task, logger));
-  router.post('/', anyCourseManagerGuard, createPostRoute(Task, logger));
-  router.put('/:id', anyCourseManagerGuard, validateTaskId, createPutRoute(Task, logger));
-
   return router;
 }
diff --git a/server/src/routes/taskResult/index.ts b/server/src/routes/taskResult/index.ts
diff --git a/server/src/routes/utils.ts b/server/src/routes/utils.ts
@@ -1,6 +1,5 @@
 import { IApiResponse } from '../models';
 import Router from '@koa/router';
-import * as crypto from 'crypto';
 import moment from 'moment-timezone';
 
 export function setResponse<T>(
@@ -41,24 +40,5 @@ export function setCsvResponse(
   return ctx;
 }
 
-export function setIcalResponse(ctx: Router.RouterContext | Router.RouterContext<any, any>, data: string) {
-  ctx.status = 200;
-  ctx.body = data;
-  ctx.res.setHeader('Content-Type', 'text/calendar');
-  return ctx;
-}
-
-export function createComparisonSignature(body: any, secret: string) {
-  const hmac = crypto.createHmac('sha1', secret);
-  const selfSignature = hmac.update(JSON.stringify(body)).digest('hex');
-  return `sha1=${selfSignature}`;
-}
-
-export function compareSignatures(signature: string, comparisonSignature: string) {
-  const source = Buffer.from(signature);
-  const comparison = Buffer.from(comparisonSignature);
-  return crypto.timingSafeEqual(source, comparison);
-}
-
 export const dateFormatter = (date: string, timeZone: string, format: string) =>
   date ? moment(date).tz(timeZone).format(format) : '';

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM node:20-alpine`
	`1`	`+FROM node:22-alpine`
`2`	`2`
`3`	`3`	`EXPOSE 8080`
`4`	`4`