[RF] Protect RooSimultaneous against missing pdf for current state

will-cern · dpiparo · commit 85287798ae65 · 2025-08-22T19:25:47.000+02:00
A user encountered a nasty crash when evaluating a pdf that didn't have the current state pdf defined for it. Should just return 0, not crash out!
diff --git a/roofit/roofitcore/src/RooSimultaneous.cxx b/roofit/roofitcore/src/RooSimultaneous.cxx
@@ -447,6 +447,9 @@ double RooSimultaneous::evaluate() const
 {
    // Retrieve the proxy by index name
    RooRealProxy *proxy = static_cast<RooRealProxy *>(_pdfProxyList.FindObject(_indexCat.label()));
+   if(!proxy) {
+      return 0;
+   }
 
    double nEvtTot = 1.0;
    double nEvtCat = 1.0;

Original file line number	Diff line number	Diff line change
`@@ -447,6 +447,9 @@ double RooSimultaneous::evaluate() const`
`447`	`447`	`{`
`448`	`448`	`// Retrieve the proxy by index name`
`449`	`449`	`RooRealProxy proxy = static_cast<RooRealProxy >(_pdfProxyList.FindObject(_indexCat.label()));`
	`450`	`+ if(!proxy) {`
	`451`	`+ return 0;`
	`452`	`+ }`
`450`	`453`
`451`	`454`	`double nEvtTot = 1.0;`
`452`	`455`	`double nEvtCat = 1.0;`